Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1265657

Re: [PATCH 21/26] Input: synaptics-rmi4: Add support for F12

Show all headers | View raw

On Fri, Nov 6, 2015 at 12:42 AM, Andrew Duggan <aduggan@synaptics.com> wrote:

> Function 12 implements 2D touch position sensor for newer Synaptics touch
> devices. It replaces F11 and no device will contain both functions.
>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
(...)
> +config RMI4_F12
> +       bool "RMI4 Function 12 (2D pointing)"
> +       depends on RMI4_2D_SENSOR

So this properly depends on RMI4_2D_SENSOR (you missed this for F11
IIUC).

But I think the approach to have it select RMI4_2D_SENSOR (which is
to be hidden) is a better approach.

This stand-alone F12 patch is nice though, that is how all patches
should look: add a function.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 21/26] Input: synaptics-rmi4: Add support for F12 Andrew Duggan <aduggan@synaptics.com> - 2015-11-06 00:50 +0100
  Re: [PATCH 21/26] Input: synaptics-rmi4: Add support for F12 Linus Walleij <linus.walleij@linaro.org> - 2015-11-09 14:30 +0100

csiph-web