Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1265502

Re: [RFC] usb: dwc2: hcd: fix split schedule issue

Show all headers | View raw

hi Doug

在 2015/11/7 7:56, Doug Anderson 写道:
> lyz@,
>
> On Fri, Nov 6, 2015 at 1:36 AM, Yunzhi Li <lyz@rock-chips.com> wrote:
>> Fix dwc2 split schedule sequence issue. Not schedule a SSPLIT_IN
>> packet between SSPLIT-begin and SSPLIT-end.
>>
>> Signed-off-by: Yunzhi Li <lyz@rock-chips.com>
>> ---
>>   drivers/usb/dwc2/hcd.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
>> index e79baf7..a32ed01 100644
>> --- a/drivers/usb/dwc2/hcd.c
>> +++ b/drivers/usb/dwc2/hcd.c
>> @@ -1122,6 +1122,10 @@ static void dwc2_process_periodic_channels(struct dwc2_hsotg *hsotg)
>>                          break;
>>                  }
>>
>> +               if (qh->channel->xact_pos == DWC2_HCSPLT_XACTPOS_BEGIN ||
>> +                   qh->channel->xact_pos == DWC2_HCSPLT_XACTPOS_MID)
>> +                       break;
>> +
>>                  /*
>>                   * In Slave mode, stay on the current transfer until there is
>>                   * nothing more to do or the high-bandwidth request count is
> Just a quite note to say that this doesn't seem to resolve the weird
> errors I'm seeing with the "Microsoft Wireless Keyboard 2000" that I
> have.  I see split transaction errors in a USB analyzer with just that
> hooked up behind a hub (don't even need any other USB devices).
>
> ...it is possible that there are two unrelated problems here, but it's
> also possible that there's some bigger root cause that will fix both
> of our problems.  I've been poking at things a bit too, but so far no
> luck...
>
> -Doug
>
It seems that we are debugging two different issues, your new patch which rewrite
the microframe scheduler doesn't resolve my problem. My patch fix chrome-os issue
#46547 not related to the particular Microsoft keyboard any keyboard could be used
to reproduce the issue.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC] usb: dwc2: hcd: fix split schedule issue Yunzhi Li <lyz@rock-chips.com> - 2015-11-06 10:40 +0100
  Re: [RFC] usb: dwc2: hcd: fix split schedule issue Yunzhi Li <lyz@rock-chips.com> - 2015-11-06 11:10 +0100
    Re: [RFC] usb: dwc2: hcd: fix split schedule issue Doug Anderson <dianders@chromium.org> - 2015-11-12 01:30 +0100
      Re: [RFC] usb: dwc2: hcd: fix split schedule issue John Youn <John.Youn@synopsys.com> - 2015-11-12 05:40 +0100
        Re: [RFC] usb: dwc2: hcd: fix split schedule issue Doug Anderson <dianders@chromium.org> - 2015-11-12 05:50 +0100
          Re: [RFC] usb: dwc2: hcd: fix split schedule issue John Youn <John.Youn@synopsys.com> - 2015-11-13 06:10 +0100
            Re: [RFC] usb: dwc2: hcd: fix split schedule issue Doug Anderson <dianders@chromium.org> - 2015-11-14 01:40 +0100
              Re: [RFC] usb: dwc2: hcd: fix split schedule issue Alan Stern <stern@rowland.harvard.edu> - 2015-11-14 18:40 +0100
        Re: [RFC] usb: dwc2: hcd: fix split schedule issue Yunzhi Li <lyz@rock-chips.com> - 2015-11-12 10:50 +0100
  Re: [RFC] usb: dwc2: hcd: fix split schedule issue Doug Anderson <dianders@chromium.org> - 2015-11-07 01:00 +0100
    Re: [RFC] usb: dwc2: hcd: fix split schedule issue Yunzhi Li <lyz@rock-chips.com> - 2015-11-09 11:10 +0100
      Re: [RFC] usb: dwc2: hcd: fix split schedule issue Doug Anderson <dianders@chromium.org> - 2015-11-09 15:40 +0100

csiph-web