Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1265497
| From | Johannes Stezenbach <js@sig21.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/4] tty: Abstract and encapsulate tty->closing behavior |
| Date | 2015-11-09 11:00 +0100 |
| Message-ID | <qsRp0-4HB-7@gated-at.bofh.it> (permalink) |
| References | <qsGjU-5WC-5@gated-at.bofh.it> <qsGjU-5WC-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, Nov 08, 2015 at 05:02:52PM -0500, Peter Hurley wrote:
> +void tty_ldisc_closing(struct tty_struct *tty)
> +{
> + struct tty_ldisc *ld = tty_ldisc_ref(tty);
> +
> + if (ld->ops->closing)
> + ld->ops->closing(tty);
> + if (ld)
> + tty_ldisc_deref(ld);
> +}
That looks strange. Do you need to check ld _before_ dereferencing?
Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3/4] tty: Abstract and encapsulate tty->closing behavior Peter Hurley <peter@hurleysoftware.com> - 2015-11-08 23:10 +0100
Re: [PATCH 3/4] tty: Abstract and encapsulate tty->closing behavior Johannes Stezenbach <js@sig21.net> - 2015-11-09 11:00 +0100
Re: [PATCH 3/4] tty: Abstract and encapsulate tty->closing behavior Peter Hurley <peter@hurleysoftware.com> - 2015-11-09 13:00 +0100
csiph-web