Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1265528

Re: [PATCH RESEND v2 3/4] ARM: BCM: Add SMP support for Broadcom NSP

Show all headers | View raw

On Fri, Nov 6, 2015 at 8:49 PM, Kapil Hali <kapilh@broadcom.com> wrote:

> Add SMP support for Broadcom's Northstar Plus SoC
> cpu enable method. This changes also consolidates
> iProc family's - BCM NSP and BCM Kona, platform
> SMP handling in a common file.
>
> Northstar Plus SoC is based on ARM Cortex-A9
> revision r3p0 which requires configuration for ARM
> Errata 764369 for SMP. This change adds the needed
> configuration option.
>
> Signed-off-by: Kapil Hali <kapilh@broadcom.com>

This version looks saner to me.

> +static int nsp_write_lut(void)
> +{
> +       void __iomem *sku_rom_lut;
> +       phys_addr_t secondary_startup_phy;
> +
> +       if (!secondary_boot) {
> +               pr_warn("required secondary boot register not specified\n");
> +               return -EINVAL;
> +       }
> +
> +       sku_rom_lut = ioremap_nocache((phys_addr_t)secondary_boot,
> +                                               sizeof(secondary_boot));

Why is this address not just taken directly from the device tree?

If it is not in the device tree: why?

Also give it a sane name, bcm_sec_boot_address or so.
"secondary_boot" sounds like a function you call to boot
the second core.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND v2 0/4] SMP support for Broadcom NSP Kapil Hali <kapilh@broadcom.com> - 2015-11-06 20:50 +0100
  [PATCH RESEND v2 3/4] ARM: BCM: Add SMP support for Broadcom NSP Kapil Hali <kapilh@broadcom.com> - 2015-11-06 20:50 +0100
    Re: [PATCH RESEND v2 3/4] ARM: BCM: Add SMP support for Broadcom  NSP Florian Fainelli <f.fainelli@gmail.com> - 2015-11-06 21:00 +0100
      Re: [PATCH RESEND v2 3/4] ARM: BCM: Add SMP support for Broadcom  NSP Florian Fainelli <f.fainelli@gmail.com> - 2015-11-06 21:10 +0100
    Re: [PATCH RESEND v2 3/4] ARM: BCM: Add SMP support for Broadcom NSP Linus Walleij <linus.walleij@linaro.org> - 2015-11-09 11:20 +0100
      Re: [PATCH RESEND v2 3/4] ARM: BCM: Add SMP support for Broadcom NSP Florian Fainelli <f.fainelli@gmail.com> - 2015-11-10 03:30 +0100
        Re: [PATCH RESEND v2 3/4] ARM: BCM: Add SMP support for Broadcom NSP Kapil Hali <kapilh@broadcom.com> - 2015-11-10 17:30 +0100
  [PATCH RESEND v2 4/4] ARM: BCM: Add SMP support for Broadcom 4708 Kapil Hali <kapilh@broadcom.com> - 2015-11-06 20:50 +0100
  [PATCH RESEND v2 2/4] ARM: dts: add SMP support for Broadcom NSP Kapil Hali <kapilh@broadcom.com> - 2015-11-06 21:00 +0100
  [PATCH RESEND v2 1/4] dt-bindings: add SMP enable-method for Broadcom NSP Kapil Hali <kapilh@broadcom.com> - 2015-11-06 21:00 +0100

csiph-web