Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1265455

Re: [PATCH] acpi: add support for extended IRQ to PCI link

From Jiang Liu <jiang.liu@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] acpi: add support for extended IRQ to PCI link
Date 2015-11-09 09:50 +0100
Message-ID <qsQjg-42K-5@gated-at.bofh.it> (permalink)
References <qsAHw-2kS-17@gated-at.bofh.it> <qsNbI-292-5@gated-at.bofh.it> <qsNv4-2fT-13@gated-at.bofh.it>
Organization Intel

Show all headers | View raw


On 2015/11/9 13:45, Sinan Kaya wrote:
> 
> 
> On 11/9/2015 12:24 AM, Jiang Liu wrote:
>>> +    u32 possible[ACPI_PCI_LINK_MAX_POSSIBLE];
>>> >      u8 initialized:1;
>>> >      u8 reserved:7;
>>> >  };
>> Hi Sinan,
>>     This data structure become some sort of big, any idea to reduce
>> memory consumption?
>> Thanks,
>> Gerry
>>
> Hi Gerry,
> 
> There are two constants in the code.
> 
> #define ACPI_PCI_LINK_MAX_POSSIBLE    16
> 
> I changed the data type above. Previously it was consuming 16 bytes now
> 64 bytes.
Aha, I made a mistake. ACPI_PCI_LINK_MAX_POSSIBLE hasn't been changed,
so the space increasing is not so big:)

> 
> The second one is this.
> 
> #define ACPI_MAX_IRQS 256
> 
> I changed ACPI_MAX_IRQS to 1020 from 256. Let's assume 1024.
> 
> I'm concerned about this though since you warned. This used to consume
> 1024 bytes now 4096 bytes.
> 
> static int acpi_irq_penalty[ACPI_MAX_IRQS] = {
>     PIRQ_PENALTY_ISA_ALWAYS,    /* IRQ0 timer */
> ...
> }
> 
> Sinan
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] acpi: add support for extended IRQ to PCI link Sinan Kaya <okaya@codeaurora.org> - 2015-11-08 17:10 +0100
  Re: [PATCH] acpi: add support for extended IRQ to PCI link Timur Tabi <timur@codeaurora.org> - 2015-11-08 17:20 +0100
    Re: [PATCH] acpi: add support for extended IRQ to PCI link Timur Tabi <timur@codeaurora.org> - 2015-11-09 01:10 +0100
      Re: [PATCH] acpi: add support for extended IRQ to PCI link "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-11-09 22:20 +0100
    Re: [PATCH] acpi: add support for extended IRQ to PCI link Sinan Kaya <okaya@codeaurora.org> - 2015-11-09 01:10 +0100
  Re: [PATCH] acpi: add support for extended IRQ to PCI link Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-08 21:40 +0100
    Re: [PATCH] acpi: add support for extended IRQ to PCI link Sinan Kaya <okaya@codeaurora.org> - 2015-11-09 23:40 +0100
  Re: [PATCH] acpi: add support for extended IRQ to PCI link Jiang Liu <jiang.liu@linux.intel.com> - 2015-11-09 06:30 +0100
    Re: [PATCH] acpi: add support for extended IRQ to PCI link Sinan Kaya <okaya@codeaurora.org> - 2015-11-09 06:50 +0100
      Re: [PATCH] acpi: add support for extended IRQ to PCI link Jiang Liu <jiang.liu@linux.intel.com> - 2015-11-09 09:50 +0100
      Re: [PATCH] acpi: add support for extended IRQ to PCI link Timur Tabi <timur@codeaurora.org> - 2015-11-09 15:00 +0100
        Re: [PATCH] acpi: add support for extended IRQ to PCI link Sinan Kaya <okaya@codeaurora.org> - 2015-11-09 17:30 +0100

csiph-web