Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq
Date	2015-11-09 09:20 +0100
Message-ID	<qsPQe-3Rn-5@gated-at.bofh.it> (permalink)
References	<qsFQR-5wX-9@gated-at.bofh.it> <qsGjT-5WC-1@gated-at.bofh.it> <qsK4b-8r8-9@gated-at.bofh.it> <qsPwS-3v4-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 09, 2015 at 05:02:48PM +0900, glen lee wrote:
> Hi Punit Vara,
> 
> I cannot find build errors on my build machines.
> 
> According the log which you have posted before says *wilc is undeclared in the function init_wilc_driver,
> which means WILC_SPI is selected because one of SPI or SDIO should be chosen at the moment.
> Hence, struct wilc *wilc should be compiled together.
> It looks like wilc1000 is compiled without SPI or SDIO.
> 
> Of course, there are many cases that I don't know, so you could let me know the wilc1000 build configuration?
> 
> static int __init init_wilc_driver(void)
> {
> #ifdef WILC_SPI

This should be #ifndef WILC_SDIO


> 	struct wilc *wilc;
> #endif

But the large question remains of why do we have this variable here any
way?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq Punit Vara <punitvara@gmail.com> - 2015-11-08 22:40 +0100
  Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared  *wilc and implicit declaration of init_irq Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-08 23:10 +0100
    Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared  *wilc and implicit declaration of init_irq glen lee <glen.lee@atmel.com> - 2015-11-09 03:10 +0100
      Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared  *wilc and implicit declaration of init_irq glen lee <glen.lee@atmel.com> - 2015-11-09 09:00 +0100
        Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared  *wilc and implicit declaration of init_irq Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-09 09:20 +0100
          Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared  *wilc and implicit declaration of init_irq punit vara <punitvara@gmail.com> - 2015-11-09 10:00 +0100
          Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared  *wilc and implicit declaration of init_irq glen lee <glen.lee@atmel.com> - 2015-11-09 10:00 +0100
            Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared  *wilc and implicit declaration of init_irq punit vara <punitvara@gmail.com> - 2015-11-09 10:10 +0100
              Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared  *wilc and implicit declaration of init_irq glen lee <glen.lee@atmel.com> - 2015-11-09 11:00 +0100
                Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared  *wilc and implicit declaration of init_irq punit vara <punitvara@gmail.com> - 2015-11-09 11:20 +0100
                Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared  *wilc and implicit declaration of init_irq Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-09 11:40 +0100
                Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared  *wilc and implicit declaration of init_irq punit vara <punitvara@gmail.com> - 2015-11-09 15:40 +0100
                Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared  *wilc and implicit declaration of init_irq Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-13 15:20 +0100

csiph-web