[PATCH 2/3] mm/cma: add new tracepoint, test_pages_isolated

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Joonsoo Kim <js1304@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/3] mm/cma: add new tracepoint, test_pages_isolated
Date	Mon, 09 Nov 2015 08:30:02 +0100
Message-ID	<qsP3Q-3kT-9@gated-at.bofh.it> (permalink)
References	<qsP3Q-3kT-11@gated-at.bofh.it>
X-Original-To	Andrew Morton <akpm@linux-foundation.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RZv74WWRtNtHoi804NpVU+zQnMGB8CXwz7dZ9/EUqRc=; b=QhHesb9FFxOSFVmh8S8sWAHTb1Nf5e8DoXJD4cAiqLfycNTWqqfYPxnDs5l1NIBX0u abkuWt1KfVXZD3Rvs3f7qwncVHf9n8LDCIH0an7/xE5yB8VaCDD0OkZJLLBSmA3iQlrV tJp+v8BeB1iFv6A+i3Sd2vWWB7DDZMWEJ6m+u6BiQmTyDgc1P+hJbzAoTxlSXf9aCqW4 WOqxmFDozCW5HRRDNKiIx/8s/MDxttfVj8hjQJqeZOCbEmEEa2a0z3xhuvkKbYL/VPrc LTxvK4wTWIGRDTAjnqXJ2xnfEXg/38eTYX412Rmy9QTddf7Lp2s+WwCy3mXOXxG2HVpR 3AyA==
X-Received	by 10.68.112.37 with SMTP id in5mr37724786pbb.88.1447053873605; Sun, 08 Nov 2015 23:24:33 -0800 (PST)
X-Google-Original-From	Joonsoo Kim <iamjoonsoo.kim@lge.com>
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	79
Organization	linux.* mail to news gateway
X-Original-Cc	Michal Nazarewicz <mina86@mina86.com>, Minchan Kim <minchan@kernel.org>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>
X-Original-Date	Mon, 9 Nov 2015 16:24:20 +0900
X-Original-Message-ID	<1447053861-28824-2-git-send-email-iamjoonsoo.kim@lge.com>
X-Original-References	<1447053861-28824-1-git-send-email-iamjoonsoo.kim@lge.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1265403

Show key headers only | View raw

cma allocation should be guranteeded to succeed, but, sometimes,
it could be failed in current implementation. To track down
the problem, we need to know which page is problematic and
this new tracepoint will report it.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 include/trace/events/cma.h | 26 ++++++++++++++++++++++++++
 mm/page_isolation.c        |  5 +++++
 2 files changed, 31 insertions(+)

diff --git a/include/trace/events/cma.h b/include/trace/events/cma.h
index d7cd961..82281b0 100644
--- a/include/trace/events/cma.h
+++ b/include/trace/events/cma.h
@@ -60,6 +60,32 @@ TRACE_EVENT(cma_release,
 		  __entry->count)
 );
 
+TRACE_EVENT(test_pages_isolated,
+
+	TP_PROTO(
+		unsigned long start_pfn,
+		unsigned long end_pfn,
+		unsigned long fin_pfn),
+
+	TP_ARGS(start_pfn, end_pfn, fin_pfn),
+
+	TP_STRUCT__entry(
+		__field(unsigned long, start_pfn)
+		__field(unsigned long, end_pfn)
+		__field(unsigned long, fin_pfn)
+	),
+
+	TP_fast_assign(
+		__entry->start_pfn = start_pfn;
+		__entry->end_pfn = end_pfn;
+		__entry->fin_pfn = fin_pfn;
+	),
+
+	TP_printk("start_pfn=0x%lx end_pfn=0x%lx fin_pfn=0x%lx ret=%s",
+		__entry->start_pfn, __entry->end_pfn, __entry->fin_pfn,
+		__entry->end_pfn == __entry->fin_pfn ? "success" : "fail")
+);
+
 #endif /* _TRACE_CMA_H */
 
 /* This part must be outside protection */
diff --git a/mm/page_isolation.c b/mm/page_isolation.c
index 6f5ae96..bda0fea 100644
--- a/mm/page_isolation.c
+++ b/mm/page_isolation.c
@@ -7,6 +7,8 @@
 #include <linux/pageblock-flags.h>
 #include <linux/memory.h>
 #include <linux/hugetlb.h>
+#include <trace/events/cma.h>
+
 #include "internal.h"
 
 static int set_migratetype_isolate(struct page *page,
@@ -268,6 +270,9 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
 						skip_hwpoisoned_pages);
 	spin_unlock_irqrestore(&zone->lock, flags);
 
+#ifdef CONFIG_CMA
+	trace_test_pages_isolated(start_pfn, end_pfn, pfn);
+#endif
 	return (pfn < end_pfn) ? -EBUSY : 0;
 }
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] mm/cma: add new tracepoint, test_pages_isolated Joonsoo Kim <js1304@gmail.com> - 2015-11-09 08:30 +0100
  Re: [PATCH 2/3] mm/cma: add new tracepoint, test_pages_isolated David Rientjes <rientjes@google.com> - 2015-11-10 00:00 +0100
    Re: [PATCH 2/3] mm/cma: add new tracepoint, test_pages_isolated Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-11-10 01:30 +0100
  Re: [PATCH 2/3] mm/cma: add new tracepoint, test_pages_isolated Michal Nazarewicz <mina86@mina86.com> - 2015-11-10 17:10 +0100

csiph-web