Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1265406
| From | sugar <sugar.zhang@rock-chips.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 1/3] ASoC: rockchip: i2s: add 8 channels capture support |
| Date | 2015-11-09 08:30 +0100 |
| Message-ID | <qsP3Q-3kT-15@gated-at.bofh.it> (permalink) |
| References | <qrEau-6hL-7@gated-at.bofh.it> <qrEau-6hL-17@gated-at.bofh.it> <qrO09-4jL-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11/6/2015 20:00, Mark Brown wrote:
> On Fri, Nov 06, 2015 at 09:38:09AM +0800, Sugar Zhang wrote:
>
>> + /* refine capture channels */
>> + if (!of_property_read_u32(node, "rockchip,capture-channels", &val)) {
>> + if (val >= 2 && val <= 8)
>> + rockchip_i2s_dai.capture.channels_max = val;
>> + else
>> + rockchip_i2s_dai.capture.channels_max = 2;
>> + }
>
> You should make a copy of the rockchip_i2s_dai struct in your driver
> data and modify that rather than modifying the original - what happens
> if sommeone makes a SoC with two I2S DAIs, one with many channels and
> another with only two? Samsung SoCs often have an arrangement like that
> for exmaple.
>
Yes, I agree, because this patch was merged into mainline, I will post a
new one based on the latest code to fix this, thanks.
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/3] ASoC: rockchip: i2s: add 8 channels capture support and share lrck Sugar Zhang <sugar.zhang@rock-chips.com> - 2015-11-06 02:40 +0100
[PATCH v3 1/3] ASoC: rockchip: i2s: add 8 channels capture support Sugar Zhang <sugar.zhang@rock-chips.com> - 2015-11-06 02:40 +0100
Re: [PATCH v3 1/3] ASoC: rockchip: i2s: add 8 channels capture support Mark Brown <broonie@kernel.org> - 2015-11-06 13:10 +0100
Re: [PATCH v3 1/3] ASoC: rockchip: i2s: add 8 channels capture support sugar <sugar.zhang@rock-chips.com> - 2015-11-09 08:30 +0100
[PATCH v3 2/3] Documentation: DT bindings: rockchip-i2s: add capture property Sugar Zhang <sugar.zhang@rock-chips.com> - 2015-11-06 02:40 +0100
csiph-web