Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1265209
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Sinan Kaya <okaya@codeaurora.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V3 4/4] dma: add Qualcomm Technologies HIDMA channel driver |
| Date | Sun, 08 Nov 2015 23:00:02 +0100 |
| Message-ID | <qsGae-5DX-13@gated-at.bofh.it> (permalink) |
| References | <qsqf8-3JB-11@gated-at.bofh.it> <qsqf8-3JB-13@gated-at.bofh.it> <qsF4t-4Zg-1@gated-at.bofh.it> |
| X-Original-To | Andy Shevchenko <andy.shevchenko@gmail.com> |
| User-Agent | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8; format=flowed |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 33 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | dmaengine <dmaengine@vger.kernel.org>, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, Andy Gross <agross@codeaurora.org>, linux-arm-msm@vger.kernel.org, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Vinod Koul <vinod.koul@intel.com>, Dan Williams <dan.j.williams@intel.com>, devicetree <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> |
| X-Original-Date | Sun, 8 Nov 2015 16:51:38 -0500 |
| X-Original-Message-ID | <563FC3EA.1040303@codeaurora.org> |
| X-Original-References | <1446958380-23298-1-git-send-email-okaya@codeaurora.org> <1446958380-23298-5-git-send-email-okaya@codeaurora.org> <CAHp75VebMdGRkgddoaCH_d_7hzXJt9QXqWc4yvSY=PJ-FcsRLA@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1265209 |
Show key headers only | View raw
On 11/8/2015 3:47 PM, Andy Shevchenko wrote:
>> + trca_resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> >+ if (!trca_resource) {
>> >+ rc = -ENODEV;
>> >+ goto bailout;
>> >+ }
> Why did you ignore my comment about this block?
> Remove that condition entirely.
>
>> >+
>> >+ trca = devm_ioremap_resource(&pdev->dev, trca_resource);
>> >+ if (IS_ERR(trca)) {
>> >+ rc = -ENOMEM;
>> >+ goto bailout;
>> >+ }
Sorry, I didn't quite get your comment. I thought you wanted to see
platform_get_resource and devm_ioremap_resource together.
Which one do you want me to remove?
--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH V3 4/4] dma: add Qualcomm Technologies HIDMA channel driver Sinan Kaya <okaya@codeaurora.org> - 2015-11-08 23:00 +0100 Re: [PATCH V3 4/4] dma: add Qualcomm Technologies HIDMA channel driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-08 23:10 +0100
csiph-web