[RFC PATCH 06/10] clocksource/drivers/h8300_timer8: Fix irq return value check

From	Daniel Lezcano <daniel.lezcano@linaro.org>
Newsgroups	linux.kernel
Subject	[RFC PATCH 06/10] clocksource/drivers/h8300_timer8: Fix irq return value check
Date	2015-11-08 23:40 +0100
Message-ID	<qsGMW-6dI-17@gated-at.bofh.it> (permalink)
References	<qsGMW-6dI-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The value returned in case of error for the 'irq_of_parse_and_map' function is
zero in case of error. Fix the check in the init code.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/h8300_timer8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/h8300_timer8.c b/drivers/clocksource/h8300_timer8.c
index f66cd6f..680f65b 100644
--- a/drivers/clocksource/h8300_timer8.c
+++ b/drivers/clocksource/h8300_timer8.c
@@ -230,7 +230,7 @@ static void __init h8300_8timer_init(struct device_node *node)
 	}
 
 	irq = irq_of_parse_and_map(node, 0);
-	if (irq < 0) {
+	if (!irq) {
 		pr_err("failed to get irq for clockevent\n");
 		goto unmap_reg;
 	}
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[RFC PATCH 06/10] clocksource/drivers/h8300_timer8: Fix irq return value check Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-08 23:40 +0100

csiph-web