Re: [PATCH] crypto: sun4i-ss: add missing statesize

From	Christoph Biedl <linux-kernel.bfrz@manchmal.in-ulm.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] crypto: sun4i-ss: add missing statesize
Date	2015-11-08 19:30 +0100
Message-ID	<qsCT0-3Gv-13@gated-at.bofh.it> (permalink)
References	<qrnsZ-3DY-11@gated-at.bofh.it> <qrvgS-tj-49@gated-at.bofh.it> <qrHi2-8gy-3@gated-at.bofh.it> <qsCpX-3eI-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Maxime Ripard wrote...

> > > > This patch specifiy statesize for sha1 and md5.
> > > > 
> > > > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> > > > Cc: stable@vger.kernel.org
> > > 
> > > Please also add a Fixes tag (and the stable version it applies to).
> > 
> > I don't see the point for a fixes tag as it would simply refer
> > to the original patch-set that added the driver.
> 
> What's the problem with that?

Fixes: should rather point to the commit that caused the breakage in my
opinion. Which did this by intention:

| commit 8996eafdcbad149ac0f772fb1649fbb75c482a6a
| Author: Russell King <rmk+kernel@arm.linux.org.uk>
| Date:   Fri Oct 9 20:43:33 2015 +0100
| 
|     crypto: ahash - ensure statesize is non-zero
(...)
+     This patch adds a check to prevent these drivers from registering
+     ahash algorithms until they are fixed.

Another crypto subsystem (mv_cesa) suffers from the same problem. I
have a patch ready but would prefer a consensus on these formalities
before submitting.

Aside from this, if you really need another Tested-by:, add me. And
also Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107281

    Christoph

Thread

[PATCH] crypto: sun4i-ss: add missing statesize LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-05 08:50 +0100
  Re: [PATCH] crypto: sun4i-ss: add missing statesize Chen-Yu Tsai <wens@csie.org> - 2015-11-05 11:40 +0100
  Re: [PATCH] crypto: sun4i-ss: add missing statesize Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-05 17:10 +0100
    Re: [PATCH] crypto: sun4i-ss: add missing statesize Herbert Xu <herbert@gondor.apana.org.au> - 2015-11-06 06:00 +0100
      Re: [PATCH] crypto: sun4i-ss: add missing statesize Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-08 19:00 +0100
        Re: [PATCH] crypto: sun4i-ss: add missing statesize Christoph Biedl <linux-kernel.bfrz@manchmal.in-ulm.de> - 2015-11-08 19:30 +0100
          Re: [PATCH] crypto: sun4i-ss: add missing statesize Herbert Xu <herbert@gondor.apana.org.au> - 2015-11-09 05:00 +0100
            Re: [PATCH] crypto: sun4i-ss: add missing statesize Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-11 23:30 +0100

csiph-web