Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump labels

From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump labels
Date	2015-11-08 17:20 +0100
Message-ID	<qsARc-2oy-17@gated-at.bofh.it> (permalink)
References	(2 earlier) <qs9QZ-1CF-9@gated-at.bofh.it> <qsf0m-4OL-13@gated-at.bofh.it> <qsf0m-4OL-11@gated-at.bofh.it> <qsfa2-58t-17@gated-at.bofh.it> <qsfa2-58t-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Nov 7, 2015 at 9:08 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Sat, 7 Nov 2015, Andy Lutomirski wrote:
>> On Sat, Nov 7, 2015 at 8:58 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
>> True.  But I hid it in a header file, too, but it was just a different
>> header file -- I had it all hidden away as CALL_ENTER_FROM_USER_MODE.
>
> It probably does not really make a difference :)
>
> I just got triggered by you saying:
>
>> Unfortunately, these only work if HAVE_JUMP_LABEL ....
>

Looking again, my patch is crappy is one obvious respect: on
non-HAVE_JUMP_LABEL kernels, I'm still generating a macro that will
compile but do the wrong thing.  I'll add better comments and the
correct ifdef in v2.  That will make it much harder to screw up
without causing a compiler error.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/4] x86 entry stuff, maybe for 4.4 Andy Lutomirski <luto@kernel.org> - 2015-11-07 00:20 +0100
  [PATCH 4/4] x86/entry/64: Bypass enter_from_user_mode on non-context-tracking boots Andy Lutomirski <luto@kernel.org> - 2015-11-07 00:20 +0100
    Re: [PATCH 4/4] x86/entry/64: Bypass enter_from_user_mode on  non-context-tracking boots Ingo Molnar <mingo@kernel.org> - 2015-11-09 10:00 +0100
  [PATCH 3/4] x86/asm: Add asm macros for static keys/jump labels Andy Lutomirski <luto@kernel.org> - 2015-11-07 00:20 +0100
    Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump  labels Thomas Gleixner <tglx@linutronix.de> - 2015-11-07 12:30 +0100
      Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump  labels Thomas Gleixner <tglx@linutronix.de> - 2015-11-07 18:00 +0100
        Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump  labels Thomas Gleixner <tglx@linutronix.de> - 2015-11-07 18:10 +0100
          Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump labels Andy Lutomirski <luto@amacapital.net> - 2015-11-07 19:20 +0100
            Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump labels Peter Zijlstra <peterz@infradead.org> - 2015-11-09 10:50 +0100
          Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump labels Andy Lutomirski <luto@amacapital.net> - 2015-11-08 17:20 +0100
        Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump labels Andy Lutomirski <luto@amacapital.net> - 2015-11-07 18:10 +0100
      Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump labels Andy Lutomirski <luto@amacapital.net> - 2015-11-07 18:00 +0100

csiph-web