Re: [PATCH 00/13] High performance balancing logic for big.LITTLE

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 00/13] High performance balancing logic for big.LITTLE
Date	Sat, 07 Nov 2015 11:00:01 +0100
Message-ID	<qs8rT-Av-5@gated-at.bofh.it> (permalink)
References	<qrO09-4jL-7@gated-at.bofh.it>
X-Original-To	Arseniy Krasnov <a.krasnov@samsung.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2012-12-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	linux@arm.linux.org.uk, mingo@redhat.com, v.tyrtov@samsung.com, s.rogachev@samsung.com, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 7 Nov 2015 10:52:37 +0100
X-Original-Message-ID	<20151107095237.GS3604@twins.programming.kicks-ass.net>
X-Original-References	<1446811367-23783-1-git-send-email-a.krasnov@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1264784

Show key headers only | View raw

No, no, no, no.

This is horrible and exactly what I've been telling people I do not want
to see.

This is very arch specific scheduler code, and very badly done. It
doesn't even call the groups big and little, it goes so far as to put a7
and a15 in sched domain member names.

It doesn't get topology information from device tree but from hard coded
CONFIG strings.

It introduces a swap_task function while we already have one.

It doesn't integrate with any of the other bits that make up and
influence energy consumption such as cpuidle and cpufreq (very minor one
way).

It doesn't mention the existing energy-aware-scheduling effort, nor how
that approach cannot be made to work for this.

It has a completely broken SoB chain.

It introduces new metrics (like druntime) without first defining them;
and in general very poor Changelogs.

In general, this makes me very sad. Please start by participating in the
existing discussion.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/13] High performance balancing logic for big.LITTLE Arseniy Krasnov <a.krasnov@samsung.com> - 2015-11-06 13:10 +0100
  [PATCH 01/13] hperf_hmp: add new config for arm and arm64. Arseniy Krasnov <a.krasnov@samsung.com> - 2015-11-06 13:10 +0100
  [PATCH 02/13] hperf_hmp: introduce hew domain flag. Arseniy Krasnov <a.krasnov@samsung.com> - 2015-11-06 13:10 +0100
  [PATCH 13/13] hperf_hmp: cpufreq routines. Arseniy Krasnov <a.krasnov@samsung.com> - 2015-11-06 13:10 +0100
  [PATCH 07/13] hperf_hmp: migration auxiliary functions. Arseniy Krasnov <a.krasnov@samsung.com> - 2015-11-06 13:10 +0100
    Re: [PATCH 07/13] hperf_hmp: migration auxiliary functions. kbuild test robot <lkp@intel.com> - 2015-11-06 14:10 +0100
  [PATCH 10/13] hperf_hmp: idle pull function. Arseniy Krasnov <a.krasnov@samsung.com> - 2015-11-06 13:10 +0100
  [PATCH 08/13] hperf_hmp: swap tasks function. Arseniy Krasnov <a.krasnov@samsung.com> - 2015-11-06 13:10 +0100
  [PATCH 05/13] hperf_hmp: introduce druntime metric. Arseniy Krasnov <a.krasnov@samsung.com> - 2015-11-06 13:10 +0100
  Re: [PATCH 00/13] High performance balancing logic for big.LITTLE Peter Zijlstra <peterz@infradead.org> - 2015-11-07 11:00 +0100

csiph-web