Re: [PATCH] HID: hid-gfrm: avoid warning for input_configured API change

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] HID: hid-gfrm: avoid warning for input_configured API change
Date	2015-11-05 19:30 +0100
Message-ID	<qrxsl-1NA-5@gated-at.bofh.it> (permalink)
References	<qqLe3-41D-27@gated-at.bofh.it> <qqPAZ-72R-3@gated-at.bofh.it> <qqTuV-13x-1@gated-at.bofh.it> <qr2HU-74Q-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 04, 2015 at 10:32:24AM +0100, Jiri Kosina wrote:
> On Tue, 3 Nov 2015, Dmitry Torokhov wrote:
> 
> > > > The input_configured callback was recently changed to return
> > > > an 'int', but the newly added driver uses the old API:
> > > >
> > > > drivers/hid/hid-gfrm.c:151:22: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
> > > >
> > > > This changes the driver like the other ones.
> > > >
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > 
> > > Acked-by: Petri Gynther <pgynther@google.com>
> > 
> > Hmm, the question is how to merge this, given that one change is in
> > Jiri's tree and another in mine...
> 
> In this case probably the best course of action is you cherry-picking 
> b2c68a2f1bab from my tree into yours, and proceeding further. git can 
> handle doubled commits (that will end up in Linus' tree eventually) 
> easily.
> 
> Another option would be to create a joint merge tree that'd contain both 
> branches merged together and proceed further from that, but I don't think 
> it's worth the hassle for simple case like this.
> 
> Works for you?

I went the cherry-pick route.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] HID: hid-gfrm: avoid warning for input_configured API change Arnd Bergmann <arnd@arndb.de> - 2015-11-03 16:00 +0100
  Re: [PATCH] HID: hid-gfrm: avoid warning for input_configured API change Petri Gynther <pgynther@google.com> - 2015-11-03 20:40 +0100
    Re: [PATCH] HID: hid-gfrm: avoid warning for input_configured API  change Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-04 00:50 +0100
      Re: [PATCH] HID: hid-gfrm: avoid warning for input_configured API  change Jiri Kosina <jikos@kernel.org> - 2015-11-04 10:40 +0100
        Re: [PATCH] HID: hid-gfrm: avoid warning for input_configured API  change Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-05 19:30 +0100

csiph-web