Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1263349
| From | LABBE Corentin <clabbe.montjoie@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] gpio: 74xx: fix a possible NULL dereference |
| Date | 2015-11-05 17:00 +0100 |
| Message-ID | <qrv7d-9F-31@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
of_match_device could return NULL, and so cause a NULL pointer dereference later at line 132: priv->flags = (uintptr_t) of_id->data; Reported-by: coverity (CID 1324141) Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> --- drivers/gpio/gpio-74xx-mmio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-74xx-mmio.c b/drivers/gpio/gpio-74xx-mmio.c index 6ed7c0f..4a7be0f 100644 --- a/drivers/gpio/gpio-74xx-mmio.c +++ b/drivers/gpio/gpio-74xx-mmio.c @@ -120,6 +120,9 @@ static int mmio_74xx_gpio_probe(struct platform_device *pdev) void __iomem *dat; int err; + if (!of_id) + return -ENODEV; + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; -- 2.4.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] gpio: 74xx: fix a possible NULL dereference LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-05 17:00 +0100
Re: [PATCH] gpio: 74xx: fix a possible NULL dereference Alexandre Courbot <gnurou@gmail.com> - 2015-11-09 01:30 +0100
Re: [PATCH] gpio: 74xx: fix a possible NULL dereference Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-09 15:20 +0100
Re: [PATCH] gpio: 74xx: fix a possible NULL dereference LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-10 08:20 +0100
csiph-web