Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1263344

Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO

From Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups linux.kernel
Subject Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO
Date 2015-11-05 17:00 +0100
Message-ID <qrv7c-9F-7@gated-at.bofh.it> (permalink)
References <qr4qm-8db-23@gated-at.bofh.it> <qrrGh-6Az-1@gated-at.bofh.it> <qrukN-8kv-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 2015-11-05 at 16:00 +0100, Jason A. Donenfeld wrote:

> Right -- I saw the expansion in the header file -- it gets the various
> TSOs plus UFO. So what this means is that the packet hasn't yet been
> split up? So were I to add this option, then my driver would have to
> be responsible for splitting up the super-packets manually? In which
> case, there would be no performance benefit in using it, since GSO
> already does this just prior to ndo_start_xmit? Or would there be a
> performance benefit in receiving the super-packets and splitting them
> myself?

It is a performance benefit only if you use the helpers from
net/core/tso.c as some drivers already do.

Otherwise, calling the skb_gso_segment() from your driver has no gain
compared to the one done from core networking stack.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-11-04 12:30 +0100
  Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO Herbert Xu <herbert@gondor.apana.org.au> - 2015-11-05 13:20 +0100
    Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-11-05 16:10 +0100
      Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO Eric Dumazet <eric.dumazet@gmail.com> - 2015-11-05 17:00 +0100
        Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-11-05 17:30 +0100
          Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-11-06 02:40 +0100
            Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO Herbert Xu <herbert@gondor.apana.org.au> - 2015-11-06 06:00 +0100
              Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-11-06 12:50 +0100

csiph-web