Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1263307

Re: [PATCH 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec
Date 2015-11-05 16:00 +0100
Message-ID <qrub8-81X-29@gated-at.bofh.it> (permalink)
References <qrqhc-5qX-13@gated-at.bofh.it> <qrqhc-5qX-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Nov 05, 2015 at 10:43:15AM +0000, Adam Thomson wrote:

> +- dlg,ldo-lvl : Required internal LDO voltage (mV) level
> +	[<1050>, <1100>, <1200>, <1400>]

Why would this ever be anything other than the minimum voltage, and
might we not want to vary it at runtime?

> +- dlg,biquad-cfg : List of data & address pairs to configure BiQuad filters
> +	[ < {data1} {addr1} {data2} {addr2} ... >; ]
> +- dlg,st-biquad-cfg : List of data & address pairs to configure Sidetone
> +		      BiQuad filters
> +	[ < {data1} {addr1} {data2} {addr2} ... >; ]

These look like DSP coefficients which I would therefore expect to be
configurable at runtime via a binary control rather than specified in
the DT - why are they in the DT?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio  codec Adam Thomson <Adam.Thomson.Opensource@diasemi.com> - 2015-11-05 11:50 +0100
  Re: [PATCH 1/2] ASoC: da7218: Add bindings documentation for DA7218  audio codec Mark Brown <broonie@kernel.org> - 2015-11-05 16:00 +0100
    RE: [PATCH 1/2] ASoC: da7218: Add bindings documentation for DA7218  audio codec "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2015-11-05 19:00 +0100
      Re: [PATCH 1/2] ASoC: da7218: Add bindings documentation for DA7218  audio codec Mark Brown <broonie@kernel.org> - 2015-11-06 11:40 +0100

csiph-web