Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1263329

Re: [PATCH 3/4] scsi: fix compiler warning for sg

From Timur Tabi <timur@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH 3/4] scsi: fix compiler warning for sg
Date 2015-11-05 16:30 +0100
Message-ID <qruEa-8ru-9@gated-at.bofh.it> (permalink)
References <qrkEO-1Qt-9@gated-at.bofh.it> <qrkEO-1Qt-7@gated-at.bofh.it> <qrop4-4fa-13@gated-at.bofh.it> <qruuu-8oo-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Sinan Kaya wrote:
 >
 >
 > #define MULDIV(X,MUL,DIV)    mult_frac64(X, MUL, DIV)

Why bother with the macro at all? Just change the code to use do_div() 
directly. It's possible that the original code was written before 
do_div() became standard, or the developer didn't know about, which is 
why we have this macro in the first place.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3/4] scsi: fix compiler warning for sg Sinan Kaya <okaya@codeaurora.org> - 2015-11-05 05:50 +0100
  Re: [PATCH 3/4] scsi: fix compiler warning for sg kbuild test robot <lkp@intel.com> - 2015-11-05 06:50 +0100
  Re: [PATCH 3/4] scsi: fix compiler warning for sg kbuild test robot <lkp@intel.com> - 2015-11-05 08:00 +0100
  Re: [PATCH 3/4] scsi: fix compiler warning for sg kbuild test robot <lkp@intel.com> - 2015-11-05 08:10 +0100
  Re: [PATCH 3/4] scsi: fix compiler warning for sg Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-05 09:50 +0100
    Re: [PATCH 3/4] scsi: fix compiler warning for sg Sinan Kaya <okaya@codeaurora.org> - 2015-11-05 16:20 +0100
      Re: [PATCH 3/4] scsi: fix compiler warning for sg Timur Tabi <timur@codeaurora.org> - 2015-11-05 16:30 +0100
      Re: [PATCH 3/4] scsi: fix compiler warning for sg Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-05 19:10 +0100
        Re: [PATCH 3/4] scsi: fix compiler warning for sg Sinan Kaya <okaya@codeaurora.org> - 2015-11-05 19:40 +0100
          Re: [PATCH 3/4] scsi: fix compiler warning for sg Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-05 20:40 +0100
            Re: [PATCH 3/4] scsi: fix compiler warning for sg Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-11-05 21:00 +0100
              Re: [PATCH 3/4] scsi: fix compiler warning for sg Sinan Kaya <okaya@codeaurora.org> - 2015-11-05 21:20 +0100
              Re: [PATCH 3/4] scsi: fix compiler warning for sg Sinan Kaya <okaya@codeaurora.org> - 2015-11-09 02:20 +0100

csiph-web