Re: [PATCH] staging: most: Delete an unnecessary check before the function call "module_put"

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: most: Delete an unnecessary check before the function call "module_put"
Date	2015-11-05 15:00 +0100
Message-ID	<qrtf5-7pc-35@gated-at.bofh.it> (permalink)
References	(5 earlier) <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <qrt5n-7ln-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Relying on hidden sanity checks makes the code harder to read.  A human
being cannot remember which functions have sanity checks and which do
not.  These sorts of patches are easy to generate automatically but they
make the code worse.  There are so many *better* things to do instead of
focusing on making the code bad.

Please stop sending these patches for drivers/staging.  You are welcome
to send them for other subsystems which I don't care about.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] staging: most: Delete an unnecessary check before the  function call "module_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-05 14:50 +0100
  Re: [PATCH] staging: most: Delete an unnecessary check before the  function call "module_put" Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-05 15:00 +0100
    Re: staging: most: Delete an unnecessary check before the function  call "module_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-05 15:10 +0100

csiph-web