Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1263218
| From | Evgeniy Polyakov <zbr@ioremap.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] w1: w1_process() is not freezable kthread |
| Date | 2015-11-05 14:50 +0100 |
| Message-ID | <qrt5o-7ln-27@gated-at.bofh.it> (permalink) |
| References | <qnIZ4-4nx-3@gated-at.bofh.it> <qodzQ-6jT-29@gated-at.bofh.it> <qort9-6PV-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi 28.10.2015, 08:26, "Jiri Kosina" <jikos@kernel.org>: > On Tue, 27 Oct 2015, Evgeniy Polyakov wrote: > >> > w1_process() calls try_to_freeze(), but the thread doesn't mark itself >> > freezable through set_freezable(), so the try_to_freeze() call is useless. >> >> I believe it is better to mark it freezable, what do you think? Its task >> is useless if anyone else goes sleeping, it should freeze too. > > I fail to see why this kthread should be freezable at all. There is no way > for w1 device to generate new I/O requests that should be written out to > filesystem, is it? w1 doesn't generate such requests, but it was more to make this thread consistent with majority of other threads in the kernel. Ok, I'm not against it, Greg please pull this patch into your tree. Acked-by: Evgeniy Polyakov <zbr@ioremap.net> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] w1: w1_process() is not freezable kthread Evgeniy Polyakov <zbr@ioremap.net> - 2015-11-05 14:50 +0100
csiph-web