[PATCH V2 1/4] PM / OPP: Propagate error properly from dev_pm_opp_set_sharing_cpus()

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH V2 1/4] PM / OPP: Propagate error properly from dev_pm_opp_set_sharing_cpus()
Date	2015-11-05 10:00 +0100
Message-ID	<qroyL-4iE-23@gated-at.bofh.it> (permalink)
References	<qroyK-4iE-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

We are returning 0 even in case of errors, fix it.

Cc: 4.3 <stable@vger.kernel.org> # 4.3
Fixes: 8d4d4e98acd6 ("PM / OPP: Add helpers for initializing CPU OPPs")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/base/power/opp/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/power/opp/cpu.c b/drivers/base/power/opp/cpu.c
index c27a1cdffec9..2139c9d4c447 100644
--- a/drivers/base/power/opp/cpu.c
+++ b/drivers/base/power/opp/cpu.c
@@ -156,7 +156,7 @@ int dev_pm_opp_set_sharing_cpus(struct device *cpu_dev, cpumask_var_t cpumask)
 out_rcu_read_unlock:
 	rcu_read_unlock();
 
-	return 0;
+	return ret;
 }
 EXPORT_SYMBOL_GPL(dev_pm_opp_set_sharing_cpus);
 
-- 
2.6.2.198.g614a2ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH V2 1/4] PM / OPP: Propagate error properly from dev_pm_opp_set_sharing_cpus() Viresh Kumar <viresh.kumar@linaro.org> - 2015-11-05 10:00 +0100

csiph-web