Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1262992

Re: [PATCH 1/5] mm, page_owner: print migratetype of a page, not pageblock

Show all headers | View raw

On Thu, Nov 05, 2015 at 09:15:01AM +0100, Vlastimil Babka wrote:
> On 11/05/2015 09:09 AM, Joonsoo Kim wrote:
> > On Wed, Nov 04, 2015 at 04:00:57PM +0100, Vlastimil Babka wrote:
> >> The information in /sys/kernel/debug/page_owner includes the migratetype
> >> declared during the page allocation via gfp_flags. This is also checked against
> >> the pageblock's migratetype, and reported as Fallback allocation if these two
> >> differ (although in fact fallback allocation is not the only reason why they
> >> can differ).
> >> 
> >> However, the migratetype actually printed is the one of the pageblock, not of
> >> the page itself, so it's the same for all pages in the pageblock. This is
> >> apparently a bug, noticed when working on other page_owner improvements. Fixed.
> > 
> > We can guess page migratetype through gfp_mask output although it isn't
> > easy task for now. But, there is no way to know pageblock migratetype.
> > I used this to know how memory is fragmented.
> 
> Ah, I see. How bout just we print both migratetypes then and remove the
> "Fallback" part, which can be trivially deduced from them (and as I noted it's
> somewhat misleading anyway)?

I'm okay with your new suggestion.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] page_owner improvements for debugging Vlastimil Babka <vbabka@suse.cz> - 2015-11-04 16:10 +0100
  [PATCH 4/5] mm, page_owner: track last migrate reason Vlastimil Babka <vbabka@suse.cz> - 2015-11-04 16:10 +0100
  [PATCH 5/5] mm, page_owner: dump page owner info from dump_page() Vlastimil Babka <vbabka@suse.cz> - 2015-11-04 16:10 +0100
    Re: [PATCH 5/5] mm, page_owner: dump page owner info from dump_page() "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-11-04 20:50 +0100
      Re: [PATCH 5/5] mm, page_owner: dump page owner info from dump_page() Sasha Levin <sasha.levin@oracle.com> - 2015-11-04 21:20 +0100
        Re: [PATCH 5/5] mm, page_owner: dump page owner info from dump_page() "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-11-04 21:50 +0100
  [PATCH 1/5] mm, page_owner: print migratetype of a page, not pageblock Vlastimil Babka <vbabka@suse.cz> - 2015-11-04 16:10 +0100
    Re: [PATCH 1/5] mm, page_owner: print migratetype of a page, not  pageblock Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-11-05 09:10 +0100
      Re: [PATCH 1/5] mm, page_owner: print migratetype of a page, not  pageblock Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-11-05 09:20 +0100
      Re: [PATCH 1/5] mm, page_owner: print migratetype of a page, not  pageblock Vlastimil Babka <vbabka@suse.cz> - 2015-11-05 09:20 +0100
  [PATCH 2/5] mm, page_owner: convert page_owner_inited to static key Vlastimil Babka <vbabka@suse.cz> - 2015-11-04 16:10 +0100

csiph-web