Re: [PATCH] net: stmmac: remove unneeded phy_iface variable

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: stmmac: remove unneeded phy_iface variable
Date	2015-11-05 06:40 +0100
Message-ID	<qrlrc-2q8-23@gated-at.bofh.it> (permalink)
References	<qrcxz-59d-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: LABBE Corentin <clabbe.montjoie@gmail.com>
Date: Wed,  4 Nov 2015 21:08:12 +0100

> The variable phy_iface is double-initialized and finally is not necessary
> at all.
> 
> Reported-by: coverity (CID 1271141)
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>

The value is used in two locations, so having it computed once in a
variable is useful.

Please just eliminate the double assignment.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: stmmac: remove unneeded phy_iface variable LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-11-04 21:10 +0100
  Re: [PATCH] net: stmmac: remove unneeded phy_iface variable David Miller <davem@davemloft.net> - 2015-11-05 06:40 +0100

csiph-web