Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1262842

Re: [PATCH v4 09/10] xen/blkfront: make persistent grants per-queue

Show all headers | View raw

On Mon, Nov 02, 2015 at 12:21:45PM +0800, Bob Liu wrote:
> Make persistent grants per-queue/ring instead of per-device, so that we can
> drop the 'dev_lock' and get better scalability.

And what is the performance value for this? How much better
scalability do you get with this?
.. snip..
> @@ -1010,6 +1002,23 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo)
>  		}
>  	}
>  
> +	/* Remove all persistent grants */

Missing full stop.
> +	if (!list_empty(&rinfo->grants)) {
> +		list_for_each_entry_safe(persistent_gnt, n,
> +					 &rinfo->grants, node) {
> +			list_del(&persistent_gnt->node);
> +			if (persistent_gnt->gref != GRANT_INVALID_REF) {
> +				gnttab_end_foreign_access(persistent_gnt->gref,
> +							  0, 0UL);
> +				rinfo->persistent_gnts_c--;
> +			}
> +			if (info->feature_persistent)
> +				__free_page(pfn_to_page(persistent_gnt->pfn));
> +			kfree(persistent_gnt);
> +		}
> +	}
> +	BUG_ON(rinfo->persistent_gnts_c != 0);
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 00/10] xen-block: multi hardware-queues/rings support Bob Liu <bob.liu@oracle.com> - 2015-11-02 05:30 +0100
  [PATCH v4 05/10] xen/blkfront: negotiate number of queues/rings to be used with backend Bob Liu <bob.liu@oracle.com> - 2015-11-02 05:30 +0100
    Re: [PATCH v4 05/10] xen/blkfront: negotiate number of queues/rings  to be used with backend Bob Liu <bob.liu@oracle.com> - 2015-11-04 02:20 +0100
      Re: [PATCH v4 05/10] xen/blkfront: negotiate number of queues/rings  to be used with backend Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2015-11-04 03:00 +0100
  [PATCH v4 04/10] xen/blkfront: split per device io_lock Bob Liu <bob.liu@oracle.com> - 2015-11-02 05:30 +0100
    Re: [PATCH v4 04/10] xen/blkfront: split per device io_lock Bob Liu <bob.liu@oracle.com> - 2015-11-04 02:10 +0100
      Re: [PATCH v4 04/10] xen/blkfront: split per device io_lock Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2015-11-04 03:00 +0100
  [PATCH v4 07/10] xen/blkback: pseudo support for multi hardware queues/rings Bob Liu <bob.liu@oracle.com> - 2015-11-02 05:30 +0100
    Re: [PATCH v4 07/10] xen/blkback: pseudo support for multi hardware  queues/rings Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2015-11-05 03:40 +0100
      Re: [PATCH v4 07/10] xen/blkback: pseudo support for multi hardware  queues/rings Bob Liu <bob.liu@oracle.com> - 2015-11-05 04:10 +0100
        Re: [PATCH v4 07/10] xen/blkback: pseudo support for multi hardware queues/rings Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2015-11-05 04:30 +0100
  [PATCH v4 09/10] xen/blkfront: make persistent grants per-queue Bob Liu <bob.liu@oracle.com> - 2015-11-02 05:30 +0100
    Re: [PATCH v4 09/10] xen/blkfront: make persistent grants per-queue Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2015-11-05 03:40 +0100
  [PATCH v4 06/10] xen/blkback: separate ring information out of struct xen_blkif Bob Liu <bob.liu@oracle.com> - 2015-11-02 05:30 +0100
  [PATCH v4 02/10] xen/blkfront: separate per ring information out of device info Bob Liu <bob.liu@oracle.com> - 2015-11-02 05:30 +0100
  [PATCH v4 08/10] xen/blkback: get the number of hardware queues/rings from blkfront Bob Liu <bob.liu@oracle.com> - 2015-11-02 05:30 +0100
    Re: [PATCH v4 08/10] xen/blkback: get the number of hardware  queues/rings from blkfront Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2015-11-05 03:40 +0100
  [PATCH v4 01/10] xen/blkif: document blkif multi-queue/ring extension Bob Liu <bob.liu@oracle.com> - 2015-11-02 05:30 +0100
  Re: [Xen-devel] [PATCH v4 00/10] xen-block: multi hardware-queues/rings  support Julien Grall <julien.grall@citrix.com> - 2015-11-02 12:30 +0100

csiph-web