Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1262749

Re: [Y2038] [PATCH] usb: misc: usbtest: Remove timeval usage

Show all headers | View raw

On Wednesday 04 November 2015 15:29:11 Deepa Dinamani wrote:
> timeval is deprecated and not y2038 safe.  Its size also changes according
> to 32 bit/ 64 bit compilation.  Replace it with 32 and 64 bit versions of
> its individual fields, giving two ioctls with different code values.
> The two ioctls are necessary to maintain the 32 bit and 64 bit userspace
> compatibility with a 64/32 bit kernel.
> 
> Change unsigned to __u32 types for a definitive userspace interface.
> This is in accordance with the psABI that the unsigned type is always
> 32 bits.
> 
> Also use motonic timer instead of real time to ensure positive delta
> values.
> 
> Refactor usbtest_ioctl for readability to isolate the handling of the
> testing timing measurement.
> 
> The official testusb userspace tool can be changed in a separate patch
> to reflect the __u32 changes as well. It can use the usbtest_param_32
> struct, since 32 bit seconds is long enough for test durations.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> 

Reviewed-by: Arnd Bergmann <arnd@arndb.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: misc: usbtest: Remove timeval usage Deepa Dinamani <deepa.kernel@gmail.com> - 2015-11-05 00:30 +0100
  Re: [Y2038] [PATCH] usb: misc: usbtest: Remove timeval usage Arnd Bergmann <arnd@arndb.de> - 2015-11-05 01:00 +0100

csiph-web