Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1262698

[patch 14/14] x86/smp: Remove single IPI wrapper

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject [patch 14/14] x86/smp: Remove single IPI wrapper
Date 2015-11-05 00:00 +0100
Message-ID <qrfc6-6Fb-21@gated-at.bofh.it> (permalink)
References <qrfc5-6Fb-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


All APIC implementation have send_IPI now. Remove the conditional in
the calling code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/kernel/smp.c |   16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

Index: linux/arch/x86/kernel/smp.c
===================================================================
--- linux.orig/arch/x86/kernel/smp.c
+++ linux/arch/x86/kernel/smp.c
@@ -115,18 +115,6 @@ static atomic_t stopping_cpu = ATOMIC_IN
 static bool smp_no_nmi_ipi = false;
 
 /*
- * Helper wrapper: not all apic definitions support sending to
- * a single CPU, so we fall back to sending to a mask.
- */
-static void send_IPI_cpu(int cpu, int vector)
-{
-	if (apic->send_IPI)
-		apic->send_IPI(cpu, vector);
-	else
-		apic->send_IPI_mask(cpumask_of(cpu), vector);
-}
-
-/*
  * this function sends a 'reschedule' IPI to another CPU.
  * it goes straight through and wastes no time serializing
  * anything. Worst case is that we lose a reschedule ...
@@ -137,12 +125,12 @@ static void native_smp_send_reschedule(i
 		WARN_ON(1);
 		return;
 	}
-	send_IPI_cpu(cpu, RESCHEDULE_VECTOR);
+	apic->send_IPI(cpu, RESCHEDULE_VECTOR);
 }
 
 void native_send_call_func_single_ipi(int cpu)
 {
-	send_IPI_cpu(cpu, CALL_FUNCTION_SINGLE_VECTOR);
+	apic->send_IPI(cpu, CALL_FUNCTION_SINGLE_VECTOR);
 }
 
 void native_send_call_func_ipi(const struct cpumask *mask)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[patch 14/14] x86/smp: Remove single IPI wrapper Thomas Gleixner <tglx@linutronix.de> - 2015-11-05 00:00 +0100
  [tip:x86/apic] x86/smp: Remove single IPI wrapper tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2015-11-05 15:50 +0100

csiph-web