Re: [PATCH 1/8] phy: rockchip-usb: fix clock get-put mismatch

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Doug Anderson <dianders@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/8] phy: rockchip-usb: fix clock get-put mismatch
Date	Thu, 05 Nov 2015 00:40:02 +0100
Message-ID	<qrfOO-78K-19@gated-at.bofh.it> (permalink)
References	<qre6l-5Zh-5@gated-at.bofh.it> <qre6m-5Zh-27@gated-at.bofh.it>
X-Original-To	Heiko Stuebner <heiko@sntech.de>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=iNNqKfhGyyPYP+Y6C3AKxqrWwscGHwYW98+vytV12q4=; b=g85ppz47TiQMP3Mvp1Spa+aqk4d8XfaczEd7a5kfgjNEo/MjUiSUfOi9y4oHLNc8OS s+HFM0kOlt6HmDsDu1OvjsyavYbNts4+2sO2FmtnOgxCGNXJHho8uZYGGMbJMUw1I3lX PEfuVfePFwaHxfvzVp2kgFlVclg1RxW0YYPUBDG/j5hZtpwYgjNWvar0L4fvKFUHDwOw rfwN3jEdtQqwAy8tU2ix+4biyYmampP6Q4XydcfbaK+W8UeQzfdBVOhnXqDf9sVqSonC U2y1clYR3V5VwjLIJnokPnSB0wKb+pHXyPSrjITPA57sw7yOaSnGDkA4MQD939BWy0en hKHQ==
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=iNNqKfhGyyPYP+Y6C3AKxqrWwscGHwYW98+vytV12q4=; b=JzmNjZ7c62q36WfH3fsfb69DcKPjwSfH3W9T7xR9dsJt+TXMTm8dUm9XQV16A+nbIY xyGQ/m0wpf69FHZko3MDxeWqISuuaBWd1/QhDGo9+ENhll42qTVDyw7K1hFQ+iaMO825 NBFONlADCSx7IK4JniT2l2kHeFpBUa+5x4aU4=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=iNNqKfhGyyPYP+Y6C3AKxqrWwscGHwYW98+vytV12q4=; b=ZRvxzsHK5fD4sY9npKaAJOjRdSg5DnsmEnfNAHiINtFao3zh2mg5R9iVIUKxSxre00 zCsWjsirpE+a8cqjYoyhsjWEvTRJWrwiiKh5HizvB/RB4XbkKcScbEcqKoOP1TYP4SOx ZOz/BBVDd/NXtUcKEAggP0p3FXy/m7NdaGY5ONycrFbeUNGyCbJkn6WgI/O1fRRkFVAK DBeLQJkwYSnsG08bGW6AiwfIDdvSds6zwJXQPv8qUOySOJXZvt8DMPs6nDUe7sib/q3E 8Yrwk74EBUweEAfAN+5z1wuWZOnyZZfAiU83lqy0XSDmpaUVQzFFRDiDFg1elIpFjmE2 hKig==
X-Gm-Message-State	ALoCoQk1ah9TtbeMoKjeZ+PjB5YH3DtanT5SlWNkvO1XOaKVHPx+UtmNAAj5ACNiheA6zJPmDIuo
MIME-Version	1.0
X-Received	by 10.13.249.4 with SMTP id j4mr2246348ywf.129.1446680099499; Wed, 04 Nov 2015 15:34:59 -0800 (PST)
X-Google-Sender-Auth	D68yAN_3_ZRzi1A3e2Z786I8trE
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	Kishon Vijay Abraham I <kishon@ti.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, Romain Perier <romain.perier@gmail.com>, Arnd Bergmann <arnd@arndb.de>
X-Original-Date	Wed, 4 Nov 2015 15:34:59 -0800
X-Original-Message-ID	<CAD=FV=X=tDxuc_wur-Bedi4PqWhe9Z3t_oaUQ1+6vQHmOSb+Qg@mail.gmail.com>
X-Original-References	<1446673454-9529-1-git-send-email-heiko@sntech.de> <1446673454-9529-2-git-send-email-heiko@sntech.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1262743

Show key headers only | View raw

Heiko

On Wed, Nov 4, 2015 at 1:44 PM, Heiko Stuebner <heiko@sntech.de> wrote:
> Currently the phy driver only gets the optional clock reference but
> never puts it again, neither during error handling nor on remove.
> Fix that by moving the clk_put to a devm-action that gets called at
> the right time when all other devm actions are done.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  drivers/phy/phy-rockchip-usb.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)

Reviewed-by: Douglas Anderson <dianders@chromium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/8] phy: rockchip-usb: correct pll handling and usb-uart Heiko Stuebner <heiko@sntech.de> - 2015-11-04 22:50 +0100
  [PATCH 3/8] phy: rockchip-usb: move per-phy init into a separate function Heiko Stuebner <heiko@sntech.de> - 2015-11-04 22:50 +0100
    Re: [PATCH 3/8] phy: rockchip-usb: move per-phy init into a separate function Doug Anderson <dianders@chromium.org> - 2015-11-05 01:00 +0100
  [PATCH 1/8] phy: rockchip-usb: fix clock get-put mismatch Heiko Stuebner <heiko@sntech.de> - 2015-11-04 22:50 +0100
    Re: [PATCH 1/8] phy: rockchip-usb: fix clock get-put mismatch Doug Anderson <dianders@chromium.org> - 2015-11-05 00:40 +0100
    Re: [PATCH 1/8] phy: rockchip-usb: fix clock get-put mismatch Kishon Vijay Abraham I <kishon@ti.com> - 2015-11-13 07:30 +0100
  [PATCH 2/8] phy: rockchip-usb: introduce a common data-struct for the device Heiko Stuebner <heiko@sntech.de> - 2015-11-04 22:50 +0100
    Re: [PATCH 2/8] phy: rockchip-usb: introduce a common data-struct for  the device Doug Anderson <dianders@chromium.org> - 2015-11-05 00:50 +0100
      Re: [PATCH 2/8] phy: rockchip-usb: introduce a common data-struct for the device Heiko Stuebner <heiko@sntech.de> - 2015-11-05 01:00 +0100
  [PATCH 4/8] phy: rockchip-usb: expose the phy-internal PLLs Heiko Stuebner <heiko@sntech.de> - 2015-11-04 22:50 +0100
    Re: [PATCH 4/8] phy: rockchip-usb: expose the phy-internal PLLs Kishon Vijay Abraham I <kishon@ti.com> - 2015-11-13 09:50 +0100
  [PATCH 7/8] ARM: dts: rockchip: assign usbphy480m_src to the new usbphy pll on veyron Heiko Stuebner <heiko@sntech.de> - 2015-11-04 22:50 +0100

csiph-web