Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1262574

Re: [PATCH RESEND] tracing: Make tracing work when debugfs is not compiled or initialized.

Show all headers | View raw

On Wed, 4 Nov 2015 10:54:42 -0800
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Wed, Nov 04, 2015 at 10:03:39AM -0500, Steven Rostedt wrote:
> > On Wed,  4 Nov 2015 09:11:18 +0800
> > Jiaxing Wang <hello.wjx@gmail.com> wrote:
> > 
> > > Currently tracing_init_dentry() returns -ENODEV when debugfs is not
> > > initialized, which causes tracefs not populated with tracing files and
> > > directories, so we will get an empty directory even after we manually
> > > mount tracefs.
> > > 
> > > We can make tracing_init_dentry() return NULL as long as tracefs
> > > is initialized and get a populated tracefs.
> > > 
> > > We also need to make global_trace.dir not NULL in order to pass the checks
> > > in tracing_get_dentry() and add_tracer_options().
> > > 
> > > Also added stub debugfs_create_automount() for when debugfs is not
> > > configured in.
> 
> The debugfs change should be split out into a separate patch, which I'll
> be glad to take through my tree, it isn't dependant on the tracing
> code at all.
> 

I guess the tracing code is dependent on that change. As the tracing
code will then be compiled without the select DEBUGFS, and will fail to
compile if that change is not there.

That said. I think it's best to split it up, and have the debugfs
change go through your tree, and the other part go through mine without
the remove of the "select DEBUGFS". After both are in mainline, then we
can remove the select statement.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/3] tracing: Make tracing work when debugfs is not  compiled or initialized. Steven Rostedt <rostedt@goodmis.org> - 2015-11-02 15:20 +0100
  [PATCH RESEND] tracing: Make tracing work when debugfs is not compiled or initialized. Jiaxing Wang <hello.wjx@gmail.com> - 2015-11-04 02:20 +0100
    Re: [PATCH RESEND] tracing: Make tracing work when debugfs is not  compiled or initialized. Steven Rostedt <rostedt@goodmis.org> - 2015-11-04 16:10 +0100
      Re: [PATCH RESEND] tracing: Make tracing work when debugfs is not  compiled or initialized. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-11-04 20:00 +0100
        Re: [PATCH RESEND] tracing: Make tracing work when debugfs is not  compiled or initialized. Steven Rostedt <rostedt@goodmis.org> - 2015-11-04 21:40 +0100
      Re: [PATCH RESEND] tracing: Make tracing work when debugfs is not  compiled or initialized. Jiaxing Wang <hello.wjx@gmail.com> - 2015-11-05 06:30 +0100
        Re: [PATCH RESEND] tracing: Make tracing work when debugfs is not  compiled or initialized. Steven Rostedt <rostedt@goodmis.org> - 2015-11-05 17:00 +0100
          [PATCH] tracing: Make tracing work when debugfs is not configured in Jiaxing Wang <hello.wjx@gmail.com> - 2015-11-06 09:10 +0100
          Re: [PATCH RESEND] tracing: Make tracing work when debugfs is not  compiled or initialized. Jiaxing Wang <hello.wjx@gmail.com> - 2015-11-06 09:10 +0100

csiph-web