Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1264598
| From | "Simmons, James A." <simmonsja@ornl.gov> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [lustre-devel] [PATCH] staging: lustre: lnet: klnds: socklnd: Move extern declarations to header |
| Date | 2015-11-06 23:10 +0100 |
| Message-ID | <qrXmP-21f-25@gated-at.bofh.it> (permalink) |
| References | <qrQEG-5PE-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>From: lustre-devel [mailto:lustre-devel-bounces@lists.lustre.org] On Behalf Of Amitoj Kaur Chawla >Sent: Friday, November 06, 2015 9:57 AM >To: oleg.drokin@intel.com; andreas.dilger@intel.com; gregkh@linuxfoundation.org; lustre-devel@lists.lustre.org; devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org >Subject: [lustre-devel] [PATCH] staging: lustre: lnet: klnds: socklnd: Move extern declarations to header > >This patch moves extern declarations in socklnd_lib.c to the respective >header file, 'socklnd.h'. > >This patch also removes extern keyword from function declarations >since functions have the extern specifier by default. > >Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> >--- > drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 3 +++ > drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 2 -- > 2 files changed, 3 insertions(+), 2 deletions(-) Acked-by: James Simmons <jsimmons@infradead.org> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h index b349847..f4fa725 100644 --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h @@ -679,6 +679,9 @@ int ksocknal_lib_recv_kiov(ksock_conn_t *conn); int ksocknal_lib_get_conn_tunables(ksock_conn_t *conn, int *txmem, int *rxmem, int *nagle); +void ksocknal_read_callback(ksock_conn_t *conn); +void ksocknal_write_callback(ksock_conn_t *conn); + int ksocknal_tunables_init(void); void ksocknal_lib_csum_tx(ksock_tx_t *tx); diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c index 679785b..04a4653 100644 --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c @@ -580,8 +580,6 @@ ksocknal_lib_push_conn(ksock_conn_t *conn) ksocknal_connsock_decref(conn); } -extern void ksocknal_read_callback(ksock_conn_t *conn); -extern void ksocknal_write_callback(ksock_conn_t *conn); /* * socket call back in Linux */ -- 1.9.1 _______________________________________________ lustre-devel mailing list lustre-devel@lists.lustre.org http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] staging: lustre: lnet: klnds: socklnd: Move extern declarations to header Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2015-11-06 16:00 +0100 RE: [lustre-devel] [PATCH] staging: lustre: lnet: klnds: socklnd: Move extern declarations to header "Simmons, James A." <simmonsja@ornl.gov> - 2015-11-06 23:10 +0100
csiph-web