Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1264368

Re: [PATCH] bcache: Really show state of work pending bit

Show all headers | View raw

On Mon, 5 Oct 2015, Petr Mladek wrote:

> WORK_STRUCT_PENDING is a mask for testing the pending bit.
> test_bit() expects the number of the bit and we need to
> use WORK_STRUCT_PENDING_BIT there.
> 
> Also work_data_bits() is defined in workqueues.h now.
> 
> I have noticed this just by chance when looking how
> WORK_STRUCT_PENDING_BIT is used. The change is compile
> tested.
> 
> Signed-off-by: Petr Mladek <pmladek@suse.com>
> ---
>  drivers/md/bcache/closure.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
> index 7a228de95fd7..9eaf1d6e8302 100644
> --- a/drivers/md/bcache/closure.c
> +++ b/drivers/md/bcache/closure.c
> @@ -167,8 +167,6 @@ EXPORT_SYMBOL(closure_debug_destroy);
>  
>  static struct dentry *debug;
>  
> -#define work_data_bits(work) ((unsigned long *)(&(work)->data))
> -
>  static int debug_seq_show(struct seq_file *f, void *data)
>  {
>  	struct closure *cl;
> @@ -182,7 +180,7 @@ static int debug_seq_show(struct seq_file *f, void *data)
>  			   r & CLOSURE_REMAINING_MASK);
>  
>  		seq_printf(f, "%s%s%s%s\n",
> -			   test_bit(WORK_STRUCT_PENDING,
> +			   test_bit(WORK_STRUCT_PENDING_BIT,

I don't see this in linux-next as of today, so I am picking it up for 4.4.

-- 
Jiri Kosina 
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] bcache: Really show state of work pending bit Jiri Kosina <jikos@kernel.org> - 2015-11-06 21:00 +0100

csiph-web