Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1264179
| From | kbuild test robot <lkp@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] mtd: mtk-nor: fix compare_const_fl.cocci warnings |
| Date | 2015-11-06 18:30 +0100 |
| Message-ID | <qrSZR-7sM-23@gated-at.bofh.it> (permalink) |
| References | <qrSZR-7sM-13@gated-at.bofh.it> <qrRr4-6mq-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
drivers/mtd/spi-nor/mtk-quadspi.c:223:6-28: Move constant to right. drivers/mtd/spi-nor/mtk-quadspi.c:214:6-10: Move constant to right. Move constants to the right of binary operators. Semantic patch information: Depends on personal taste in some cases. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Bayi Cheng <bayi.cheng@mediatek.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- Please take the patch only if it's a positive warning. Thanks! mtk-quadspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/mtd/spi-nor/mtk-quadspi.c +++ b/drivers/mtd/spi-nor/mtk-quadspi.c @@ -211,7 +211,7 @@ static int mt8173_nor_write_buffer_enabl */ writel(MTK_NOR_WR_BUF_ENABLE, mt8173_nor->base + MTK_NOR_CFG2_REG); return readb_poll_timeout(mt8173_nor->base + MTK_NOR_CFG2_REG, reg, - 0x01 == (reg & 0x01), 100, 10000); + (reg & 0x01) == 0x01, 100, 10000); } static int mt8173_nor_write_buffer_disable(struct mt8173_nor *mt8173_nor) @@ -220,7 +220,7 @@ static int mt8173_nor_write_buffer_disab writel(MTK_NOR_WR_BUF_DISABLE, mt8173_nor->base + MTK_NOR_CFG2_REG); return readb_poll_timeout(mt8173_nor->base + MTK_NOR_CFG2_REG, reg, - MTK_NOR_WR_BUF_DISABLE == (reg & 0x1), 100, + (reg & 0x1) == MTK_NOR_WR_BUF_DISABLE, 100, 10000); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v6 2/3] mtd: mtk-nor: mtk serial flash controller driver Bayi Cheng <bayi.cheng@mediatek.com> - 2015-11-06 16:50 +0100
[PATCH] mtd: mtk-nor: fix compare_const_fl.cocci warnings kbuild test robot <lkp@intel.com> - 2015-11-06 18:30 +0100
Re: [PATCH v6 2/3] mtd: mtk-nor: mtk serial flash controller driver Brian Norris <computersforpeace@gmail.com> - 2015-11-10 04:10 +0100
Re: [PATCH v6 2/3] mtd: mtk-nor: mtk serial flash controller driver bayi cheng <bayi.cheng@mediatek.com> - 2015-11-11 15:00 +0100
Re: [PATCH v6 2/3] mtd: mtk-nor: mtk serial flash controller driver Brian Norris <computersforpeace@gmail.com> - 2015-11-11 22:50 +0100
Re: [PATCH v6 2/3] mtd: mtk-nor: mtk serial flash controller driver bayi cheng <bayi.cheng@mediatek.com> - 2015-11-13 08:30 +0100
csiph-web