Re: [PATCH] bq2415x_charger: Delete unnecessary checks before the function call "of_node_put"

From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] bq2415x_charger: Delete unnecessary checks before the function call "of_node_put"
Date	2015-11-06 17:20 +0100
Message-ID	<qrRU7-6M2-19@gated-at.bofh.it> (permalink)
References	(5 earlier) <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <qrRAK-6pR-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Friday 06 November 2015 16:56:33 SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 6 Nov 2015 16:48:46 +0100
> 
> The of_node_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the calls is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Pali Rohár <pali.rohar@gmail.com>

-- 
Pali Rohár
pali.rohar@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] bq2415x_charger: Delete unnecessary checks before the  function call "of_node_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-06 17:00 +0100
  Re: [PATCH] bq2415x_charger: Delete unnecessary checks before the  function call "of_node_put" Pali Rohár <pali.rohar@gmail.com> - 2015-11-06 17:20 +0100

csiph-web