Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1264053

Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

From David Herrmann <dh.herrmann@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces
Date 2015-11-06 15:30 +0100
Message-ID <qrQbD-5DG-5@gated-at.bofh.it> (permalink)
References <qlZ7X-tR-3@gated-at.bofh.it> <qm2Iy-5OI-11@gated-at.bofh.it> <qm2Se-606-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Darren!

On Wed, Oct 21, 2015 at 4:44 PM, Darren Hart <dvhart@infradead.org> wrote:
> On Wed, Oct 21, 2015 at 12:33:52PM -0200, Henrique de Moraes Holschuh wrote:
>> On Wed, Oct 21, 2015, at 08:46, David Herrmann wrote:
>> > The thinkpad_acpi driver currently emits error messages on unsupported
>> > brightness interfaces, giving the impression that someone will implement
>> > those. However, this error is spit out on nearly every thinkpad in
>> > production since 2 years now. Furthermore, the backlight interfaces on
>> > those devices are supported by the i915 driver just fine.
>> >
>> > Downgrade the error message to a normal pr_info() and stop telling people
>> > to report it to IBM.
>>
>> IBM?  Those reports go directly to me.
>>
>> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
>>
>> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
>
> Thanks, Queued.

Any particular reason this didn't show up in:
    [GIT PULL] platform-drivers-x86 for 4.4-1

Just a kind reminder, in case it slipped through the cracks.

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces David Herrmann <dh.herrmann@gmail.com> - 2015-11-06 15:30 +0100
  Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness  interfaces Darren Hart <dvhart@infradead.org> - 2015-11-06 19:00 +0100

csiph-web