Re: [PATCH v10 1/1] pwm: core: Set enable state properly on failed call to enable

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 1/1] pwm: core: Set enable state properly on failed call to enable
Date	2015-11-06 14:50 +0100
Message-ID	<qrPyW-59d-17@gated-at.bofh.it> (permalink)
References	<qknR7-6bK-3@gated-at.bofh.it> <qknR7-6bK-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Oct 16, 2015 at 05:40:58PM -0700, Jonathan Richardson wrote:
> The pwm_enable function didn't clear the enabled bit if a call to a
> clients enable function returned an error. The result was that the state
> of the pwm core was wrong. Clearing the bit when enable returns an error
> ensures the state is properly set.
> 
> Tested-by: Jonathan Richardson <jonathar@broadcom.com>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Jonathan Richardson <jonathar@broadcom.com>
> ---
>  drivers/pwm/core.c  | 33 ++++++++++++++++++++++++++-------
>  include/linux/pwm.h |  2 ++
>  2 files changed, 28 insertions(+), 7 deletions(-)

Applied, thanks.

Thierry

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v10 1/1] pwm: core: Set enable state properly on failed  call to enable Thierry Reding <thierry.reding@gmail.com> - 2015-11-06 14:50 +0100

csiph-web