Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1263984

Re: [PATCH 11/13] hperf_hmp: task CPU selection logic.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Arseniy,

[auto build test WARNING on tip/sched/core]
[also build test WARNING on v4.3 next-20151106]

url:    https://github.com/0day-ci/linux/commits/Arseniy-Krasnov/High-performance-balancing-logic-for-big-LITTLE/20151106-200901
config: x86_64-randconfig-x018-11051832 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   kernel/sched/fair.c: In function 'select_task_rq_fair':
>> kernel/sched/fair.c:5159:6: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
      if (sd_flag & SD_BALANCE_WAKE) /* XXX always ? */
         ^

vim +/else +5159 kernel/sched/fair.c

29cd8bae kernel/sched_fair.c Peter Zijlstra  2009-09-17  5143  			break;
f03542a7 kernel/sched/fair.c Alex Shi        2012-07-26  5144  		}
29cd8bae kernel/sched_fair.c Peter Zijlstra  2009-09-17  5145  
f03542a7 kernel/sched/fair.c Alex Shi        2012-07-26  5146  		if (tmp->flags & sd_flag)
c88d5910 kernel/sched_fair.c Peter Zijlstra  2009-09-10  5147  			sd = tmp;
63b0e9ed kernel/sched/fair.c Mike Galbraith  2015-07-14  5148  		else if (!want_affine)
63b0e9ed kernel/sched/fair.c Mike Galbraith  2015-07-14  5149  			break;
c88d5910 kernel/sched_fair.c Peter Zijlstra  2009-09-10  5150  	}
4ae7d5ce kernel/sched_fair.c Ingo Molnar     2008-03-19  5151  
63b0e9ed kernel/sched/fair.c Mike Galbraith  2015-07-14  5152  	if (affine_sd) {
63b0e9ed kernel/sched/fair.c Mike Galbraith  2015-07-14  5153  		sd = NULL; /* Prefer wake_affine over balance flags */
63b0e9ed kernel/sched/fair.c Mike Galbraith  2015-07-14  5154  		if (cpu != prev_cpu && wake_affine(affine_sd, p, sync))
63b0e9ed kernel/sched/fair.c Mike Galbraith  2015-07-14  5155  			new_cpu = cpu;
8b911acd kernel/sched_fair.c Mike Galbraith  2010-03-11  5156  	}
3b640894 kernel/sched_fair.c Peter Zijlstra  2009-09-16  5157  
63b0e9ed kernel/sched/fair.c Mike Galbraith  2015-07-14  5158  	if (!sd) {
63b0e9ed kernel/sched/fair.c Mike Galbraith  2015-07-14 @5159  		if (sd_flag & SD_BALANCE_WAKE) /* XXX always ? */
9b7aaf11 kernel/sched/fair.c Arseniy Krasnov 2015-11-06  5160  			if (IS_ENABLED(CONFIG_HPERF_HMP) && sync)
9b7aaf11 kernel/sched/fair.c Arseniy Krasnov 2015-11-06  5161  				new_cpu = prev_cpu;
9b7aaf11 kernel/sched/fair.c Arseniy Krasnov 2015-11-06  5162  			else
9b7aaf11 kernel/sched/fair.c Arseniy Krasnov 2015-11-06  5163  				new_cpu = select_idle_sibling(p, prev_cpu);
9b7aaf11 kernel/sched/fair.c Arseniy Krasnov 2015-11-06  5164  	} else {
9b7aaf11 kernel/sched/fair.c Arseniy Krasnov 2015-11-06  5165  #ifdef CONFIG_HPERF_HMP
9b7aaf11 kernel/sched/fair.c Arseniy Krasnov 2015-11-06  5166  		new_cpu = hmp_select_task_rq_fair(p);
9b7aaf11 kernel/sched/fair.c Arseniy Krasnov 2015-11-06  5167  #else

:::::: The code at line 5159 was first introduced by commit
:::::: 63b0e9edceec10fa41ec33393a1515a5ff444277 sched/fair: Beef up wake_wide()

:::::: TO: Mike Galbraith <umgwanakikbuti@gmail.com>
:::::: CC: Ingo Molnar <mingo@kernel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 11/13] hperf_hmp: task CPU selection logic. Arseniy Krasnov <a.krasnov@samsung.com> - 2015-11-06 13:10 +0100
  Re: [PATCH 11/13] hperf_hmp: task CPU selection logic. kbuild test robot <lkp@intel.com> - 2015-11-06 13:40 +0100

csiph-web