Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1263998

Re: [PATCH] mm: slab: Only move management objects off-slab for sizes larger than KMALLOC_MIN_SIZE

Show all headers | View raw

On Thu, Nov 5, 2015 at 5:08 PM, Catalin Marinas <catalin.marinas@arm.com> wrote:
> From fda8f306b6941f4ddbefcbcfaa59fedef4a679a3 Mon Sep 17 00:00:00 2001
> From: Catalin Marinas <catalin.marinas@arm.com>
> Date: Thu, 5 Nov 2015 11:14:48 +0000
> Subject: [PATCH] mm: slab: Only move management objects off-slab for sizes
>  larger than KMALLOC_MIN_SIZE
>
> On systems with a KMALLOC_MIN_SIZE of 128 (arm64, some mips and powerpc
> configurations defining ARCH_DMA_MINALIGN to 128), the first
> kmalloc_caches[] entry to be initialised after slab_early_init = 0 is
> "kmalloc-128" with index 7. Depending on the debug kernel configuration,
> sizeof(struct kmem_cache) can be larger than 128 resulting in an
> INDEX_NODE of 8.
>
> Commit 8fc9cf420b36 ("slab: make more slab management structure off the
> slab") enables off-slab management objects for sizes starting with
> PAGE_SIZE >> 5 (128 bytes for a 4KB page configuration) and the creation
> of the "kmalloc-128" cache would try to place the management objects
> off-slab. However, since KMALLOC_MIN_SIZE is already 128 and
> freelist_size == 32 in __kmem_cache_create(),
> kmalloc_slab(freelist_size) returns NULL (kmalloc_caches[7] not
> populated yet). This triggers the following bug on arm64:
>
> [    0.000000] kernel BUG at /work/Linux/linux-2.6-aarch64/mm/slab.c:2283!
> [    0.000000] Internal error: Oops - BUG: 0 [#1] SMP
> [    0.000000] Modules linked in:
> [    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 4.3.0-rc4+ #540
> [    0.000000] Hardware name: Juno (DT)
> [    0.000000] task: ffffffc0006962b0 ti: ffffffc00068c000 task.ti: ffffffc00068c000
> [    0.000000] PC is at __kmem_cache_create+0x21c/0x280
> [    0.000000] LR is at __kmem_cache_create+0x210/0x280
> [...]
> [    0.000000] Call trace:
> [    0.000000] [<ffffffc000154948>] __kmem_cache_create+0x21c/0x280
> [    0.000000] [<ffffffc000652da4>] create_boot_cache+0x48/0x80
> [    0.000000] [<ffffffc000652e2c>] create_kmalloc_cache+0x50/0x88
> [    0.000000] [<ffffffc000652f14>] create_kmalloc_caches+0x4c/0xf4
> [    0.000000] [<ffffffc000654a9c>] kmem_cache_init+0x100/0x118
> [    0.000000] [<ffffffc0006447d4>] start_kernel+0x214/0x33c
>
> This patch introduces an OFF_SLAB_MIN_SIZE definition to avoid off-slab
> management objects for sizes equal to or smaller than KMALLOC_MIN_SIZE.
>
>
> Fixes: 8fc9cf420b36 ("slab: make more slab management structure off the slab")
> Cc: <stable@vger.kernel.org> # 3.15+
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Christoph Lameter <cl@linux.com>
> Cc: Pekka Enberg <penberg@kernel.org>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

Thanks a lot!

For the record (the fix is already upstream):

Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] arm64: Increase the max granular size Catalin Marinas <catalin.marinas@arm.com> - 2015-11-03 13:10 +0100
  Re: [PATCH] arm64: Increase the max granular size Catalin Marinas <catalin.marinas@arm.com> - 2015-11-03 15:40 +0100
    Re: [PATCH] arm64: Increase the max granular size Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-03 16:00 +0100
      Re: [PATCH] arm64: Increase the max granular size Catalin Marinas <catalin.marinas@arm.com> - 2015-11-03 20:00 +0100
        Re: [PATCH] arm64: Increase the max granular size Christoph Lameter <cl@linux.com> - 2015-11-04 00:40 +0100
          Re: [PATCH] arm64: Increase the max granular size Catalin Marinas <catalin.marinas@arm.com> - 2015-11-04 13:40 +0100
            Re: [PATCH] arm64: Increase the max granular size Christoph Lameter <cl@linux.com> - 2015-11-04 15:00 +0100
              Re: [PATCH] arm64: Increase the max granular size Catalin Marinas <catalin.marinas@arm.com> - 2015-11-04 16:00 +0100
                Re: [PATCH] arm64: Increase the max granular size Christoph Lameter <cl@linux.com> - 2015-11-04 16:30 +0100
                Re: [PATCH] arm64: Increase the max granular size Catalin Marinas <catalin.marinas@arm.com> - 2015-11-04 16:40 +0100
                Re: [PATCH] arm64: Increase the max granular size Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-11-05 05:40 +0100
                [PATCH] mm: slab: Only move management objects off-slab for sizes larger than KMALLOC_MIN_SIZE Catalin Marinas <catalin.marinas@arm.com> - 2015-11-05 13:00 +0100
                Re: [PATCH] mm: slab: Only move management objects off-slab for  sizes larger than KMALLOC_MIN_SIZE Andrew Morton <akpm@linux-foundation.org> - 2015-11-05 14:30 +0100
                Re: [PATCH] mm: slab: Only move management objects off-slab for  sizes larger than KMALLOC_MIN_SIZE Catalin Marinas <catalin.marinas@arm.com> - 2015-11-05 17:10 +0100
                Re: [PATCH] mm: slab: Only move management objects off-slab for sizes  larger than KMALLOC_MIN_SIZE Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-06 14:10 +0100
                Re: [PATCH] mm: slab: Only move management objects off-slab for  sizes larger than KMALLOC_MIN_SIZE Christoph Lameter <cl@linux.com> - 2015-11-05 18:40 +0100

csiph-web