Re: [RFC PATCH 3/7] spi: tegra: remove redundant "depends on RESET_CONTROLLER"

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 3/7] spi: tegra: remove redundant "depends on RESET_CONTROLLER"
Date	2015-11-06 11:30 +0100
Message-ID	<qrMro-3f3-15@gated-at.bofh.it> (permalink)
References	<qrqKe-5R7-5@gated-at.bofh.it> <qrqKe-5R7-3@gated-at.bofh.it> <qrrmW-69O-15@gated-at.bofh.it> <qrInL-JI-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Nov 06, 2015 at 03:02:57PM +0900, Masahiro Yamada wrote:
> 2015-11-05 20:50 GMT+09:00 Mark Brown <broonie@kernel.org>:
> > On Thu, Nov 05, 2015 at 08:15:24PM +0900, Masahiro Yamada wrote:
> >> ARCH_TEGRA selects RESET_CONTROLLER.
> >> The dependency "depends on RESET_CONTROLLER" is already met.

> >>       tristate "NVIDIA Tegra114 SPI Controller"
> >>       depends on (ARCH_TEGRA && TEGRA20_APB_DMA) || COMPILE_TEST
> >> -     depends on RESET_CONTROLLER && HAS_DMA
> >> +     depends on HAS_DMA

> > Again, this driver doesn't depend on ARCH_TEGRA.

> How come?

> Sorry, I have not been tracking this sub-system,
> so I do not get the "Again".

It's the same issue as your previous patch - there's an || COMPILE_TEST
in there.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 3/7] spi: tegra: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-05 12:20 +0100
  Re: [RFC PATCH 3/7] spi: tegra: remove redundant "depends on  RESET_CONTROLLER" Mark Brown <broonie@kernel.org> - 2015-11-05 13:00 +0100
    Re: [RFC PATCH 3/7] spi: tegra: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-06 07:10 +0100
      Re: [RFC PATCH 3/7] spi: tegra: remove redundant "depends on  RESET_CONTROLLER" Mark Brown <broonie@kernel.org> - 2015-11-06 11:30 +0100

csiph-web