Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1263831

RE: [PATCH v6 1/4] Documentation: dt-bindings: Describe SROMc configuration

Show all headers | View raw

 Hello!

> > +- samsung,srom-timing : array of 6 integers, specifying bank timings in the
> > +                        following order: Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs.
> > +                        Each value is specified in cycles and has the following
> > +                        meaning and valid range:
> > +                        Tacp : Page mode access cycle at Page mode (0 - 15)
> > +                        Tcah : Address holding time after CSn (0 - 15)
> > +                        Tcoh : Chip selection hold on OEn (0 - 15)
> > +                        Tacc : Access cycle (0 - 32)
> 
> All of the manuals have error here. Probably it can be either: 1-32 or
> 0-31. I would bet on 0-31, what do you think?

 Damn, everything starts from 0, so i automatically put '0 - 32'. The actual time, however, varies from 1 to 32, but the value is
from 0 to 31, i. e. <time> - 1
 What shall we do? Just document this, or adjust the code to take number of cycles and subtract 1? To tell the truth, i'm already
sick of these small fixups, and i would prefer just to fix documentation.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/4] Exynos SROMc configuration and Ethernet support for  SMDK5410 Pavel Fedin <p.fedin@samsung.com> - 2015-11-05 13:10 +0100
  [PATCH v6 2/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin <p.fedin@samsung.com> - 2015-11-05 13:10 +0100
    Re: [PATCH v6 2/4] ARM: dts: Add SROMc to Exynos 5410 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-06 01:10 +0100
  [PATCH v6 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin <p.fedin@samsung.com> - 2015-11-05 13:10 +0100
    Re: [PATCH v6 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-06 01:20 +0100
  [PATCH v6 3/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin <p.fedin@samsung.com> - 2015-11-05 13:10 +0100
  [PATCH v6 1/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin <p.fedin@samsung.com> - 2015-11-05 13:10 +0100
    Re: [PATCH v6 1/4] Documentation: dt-bindings: Describe SROMc  configuration Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-06 01:10 +0100
      Re: [PATCH v6 1/4] Documentation: dt-bindings: Describe SROMc  configuration Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-06 09:20 +0100
      RE: [PATCH v6 1/4] Documentation: dt-bindings: Describe SROMc  configuration Pavel Fedin <p.fedin@samsung.com> - 2015-11-06 09:20 +0100

csiph-web