Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1263803
| From | Andy Lutomirski <luto@amacapital.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | What's TRACE_IRQS_OFF_DEBUG for? |
| Date | 2015-11-06 08:30 +0100 |
| Message-ID | <qrJDc-1sw-11@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The comment says: /* * When dynamic function tracer is enabled it will add a breakpoint * to all locations that it is about to modify, sync CPUs, update * all the code, sync CPUs, then remove the breakpoints. In this time * if lockdep is enabled, it might jump back into the debug handler * outside the updating of the IST protection. (TRACE_IRQS_ON/OFF). * * We need to change the IDT table before calling TRACE_IRQS_ON/OFF to * make sure the stack pointer does not get reset back to the top * of the debug stack, and instead just reuses the current stack. */ #if defined(CONFIG_DYNAMIC_FTRACE) && defined(CONFIG_TRACE_IRQFLAGS) .macro TRACE_IRQS_OFF_DEBUG ... Unless I'm missing something, TRACE_IRQS_OFF isn't a tracepoint at all, though -- it's a lockdep debugging thing. Is the worry that someone might stick a kprobe or similar in the trace_hardirqs_off code? If so, could we just disable that instead? I could easily be missing something here. --Andy -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
What's TRACE_IRQS_OFF_DEBUG for? Andy Lutomirski <luto@amacapital.net> - 2015-11-06 08:30 +0100 Re: What's TRACE_IRQS_OFF_DEBUG for? Steven Rostedt <rostedt@goodmis.org> - 2015-11-06 14:40 +0100
csiph-web