Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1262408

Re: [PATCH] bnxt_en: add VXLAN dependency

Show all headers | View raw

On Wed, 2015-11-04 at 16:00 +0100, Arnd Bergmann wrote: 
> VXLAN may be a loadable module, and this driver cannot be built-in
> in that case, or we get a link error:
> 
> drivers/built-in.o: In function `__bnxt_open_nic':
> drivers/net/ethernet/broadcom/bnxt/bnxt.c:4581: undefined reference to `vxlan_get_rx_port'
> 
> This adds a Kconfig dependency that ensures that either VXLAN is
> disabled (which the driver handles correctly), or we depend on
> VXLAN itself and disallow built-in compilation when VXLAN is
> a module.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks.
Acked-by: Michael Chan <mchan@broadcom.com>

> Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
> 
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index 67a7d520d9f5..8550df189ceb 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -173,6 +173,7 @@ config SYSTEMPORT
>  config BNXT
>  	tristate "Broadcom NetXtreme-C/E support"
>  	depends on PCI
> +	depends on VXLAN || VXLAN=n
>  	select FW_LOADER
>  	select LIBCRC32C
>  	---help---
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] bnxt_en: add VXLAN dependency Arnd Bergmann <arnd@arndb.de> - 2015-11-04 16:10 +0100
  Re: [PATCH] bnxt_en: add VXLAN dependency Michael Chan <mchan@broadcom.com> - 2015-11-04 17:10 +0100
  Re: [PATCH] bnxt_en: add VXLAN dependency David Miller <davem@davemloft.net> - 2015-11-05 06:10 +0100

csiph-web