Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1262311

Re: [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init

Show all headers | View raw

On Mon, Nov 02, 2015 at 04:37:51PM +0100, Arnd Bergmann wrote:
> On Monday 02 November 2015 22:49:01 Geliang Tang wrote:
> > diff --git a/drivers/char/efirtc.c b/drivers/char/efirtc.c
> > index 5323d8c..80058bd 100644
> > --- a/drivers/char/efirtc.c
> > +++ b/drivers/char/efirtc.c
> > @@ -378,6 +378,9 @@ efi_rtc_init(void)
> >         int ret;
> >         struct proc_dir_entry *dir;
> >  
> > +       if (!efi_enabled(EFI_RUNTIME_SERVICES))
> > +               return 0;
> > 
> 
> Are there any Itanium machines that don't enable runtime services?
> This seems a little redundant otherwise.
> 
> Are you trying to run the ancient driver on non-Itanium systems?

Yes. I did run this driver on a EFI-based X86_64 machine.

Geliang Tang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] efirtc: replace 1998 with EFI_RTC_EPOCH Geliang Tang <geliangtang@163.com> - 2015-11-02 16:00 +0100
  [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init Geliang Tang <geliangtang@163.com> - 2015-11-02 16:00 +0100
    Re: [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init Arnd Bergmann <arnd@arndb.de> - 2015-11-02 16:40 +0100
      Re: [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init Geliang Tang <geliangtang@163.com> - 2015-11-04 15:50 +0100
        Re: [PATCH 2/2] efirtc: add efi_enabled check in efi_rtc_init Arnd Bergmann <arnd@arndb.de> - 2015-11-04 16:00 +0100

csiph-web