Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1262226

Re: [PATCH] block: Don't allow illegal discard requests

Show all headers | View raw

On Wed, Nov 04, 2015 at 10:18:41AM +0100, Jan Kara wrote:
> Currently blkdev_issue_discard() doesn't check that submitted discard
> request matches granularity required by the underlying device.
> Submitting such requests to the device can have unexpected consequences
> (e.g. brd driver just discards more / less data depending on how exactly
> the request is aligned). So test that submitted discard request has the
> granularity required by the driver.

How is this going to work with stacked drivers?  I think brd needs to
be fixed to take care of the granularity itself, just like we did for
request based drivers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] block: Don't allow illegal discard requests Jan Kara <jack@suse.com> - 2015-11-04 10:20 +0100
  Re: [PATCH] block: Don't allow illegal discard requests kbuild test robot <lkp@intel.com> - 2015-11-04 11:50 +0100
  Re: [PATCH] block: Don't allow illegal discard requests kbuild test robot <lkp@intel.com> - 2015-11-04 11:50 +0100
  Re: [PATCH] block: Don't allow illegal discard requests kbuild test robot <lkp@intel.com> - 2015-11-04 12:00 +0100
  Re: [PATCH] block: Don't allow illegal discard requests Christoph Hellwig <hch@infradead.org> - 2015-11-04 12:40 +0100
    Re: [PATCH] block: Don't allow illegal discard requests Jan Kara <jack@suse.cz> - 2015-11-04 15:20 +0100

csiph-web