Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1262142
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v7] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller |
| Date | 2015-11-04 10:00 +0100 |
| Message-ID | <qr25c-6Be-3@gated-at.bofh.it> (permalink) |
| References | <qqMtt-57V-31@gated-at.bofh.it> <qqMtt-57V-29@gated-at.bofh.it> <qr0Zr-5Wr-7@gated-at.bofh.it> <qr0Zr-5Wr-5@gated-at.bofh.it> <qr25c-6Be-5@gated-at.bofh.it> |
| Organization | ARM Ltd |
On 04/11/15 07:54, Bharat Kumar Gogada wrote: >>> Without #ifdefs if we compile driver for legacy, MSI structures will not be >> available and we get compile time error. >> >> Sorry for nitpicking but at least can we use elegant version of #ifdefs .i.e. #if >> IS_ENABLED() here ? >> > Since IS_ENABLED() is checked at runtime, compile time error would come for legacy. You're seriously misguided. IS_ENABLED() is specifically designed *not* to be checked at runtime, but instead to use the compiler optimization phase to get rid of code sections at compile time. M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v7] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller Marc Zyngier <marc.zyngier@arm.com> - 2015-11-03 17:20 +0100
Re: [PATCH v7] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller Amit Tomer <amittomer25@gmail.com> - 2015-11-04 08:50 +0100
Re: [PATCH v7] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller Marc Zyngier <marc.zyngier@arm.com> - 2015-11-04 10:00 +0100
Re: [PATCH v7] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller Marc Zyngier <marc.zyngier@arm.com> - 2015-11-04 09:50 +0100
Re: [PATCH v7] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller Marc Zyngier <marc.zyngier@arm.com> - 2015-11-04 16:10 +0100
csiph-web