Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

From	Brendan Gregg <brendan.d.gregg@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled
Date	2015-11-03 01:10 +0100
Message-ID	<qqxkK-3Fq-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <qmhxU-2nM-13@gated-at.bofh.it> <qmiDE-3XH-17@gated-at.bofh.it> <qmiDE-3XH-19@gated-at.bofh.it> <qmkFu-6UJ-47@gated-at.bofh.it> <qmoJ3-4Fr-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Oct 22, 2015 at 7:03 AM, Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
> Em Thu, Oct 22, 2015 at 02:49:11AM -0700, Brendan Gregg escreveu:
>> On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim <namhyung@kernel.org> wrote:
>> > Hi Ingo,
>> >
>> > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar <mingo@kernel.org> wrote:
>> >>
>> >> * Namhyung Kim <namhyung@kernel.org> wrote:
>> >>
>> >>> The caller callchain order is useful with --children option since it can
>> >>> show 'overview' style output, but other commands which don't use
>> >>>  --children feature like 'perf script' or even 'perf report/top' without
>> >>>  --children are better to keep caller order.
>> >
>> > Oops, there's a typo:  s/caller order/callee order/ :)
>>
>> Thanks, I was wondering about that (and I've made that typo myself).
>> Thanks for the patch!
>
> Brendan, can I take that as an Acked-by?

Belated, yes!

Brendan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order  only if --children is enabled Brendan Gregg <brendan.d.gregg@gmail.com> - 2015-11-03 01:10 +0100

csiph-web