Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1261041

Re: [PATCH 1/3] Tracepoint: fix documentation of RCU lockdep checks

Show all headers | View raw

On Mon,  2 Nov 2015 17:42:42 -0500
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> The documentation on top of __DECLARE_TRACE() does not match its
> implementation since the condition check has been added to the
> RCU lockdep checks. Update the documentation to match its
> implementation.
> 

Thanks, I can pull this now for 4.4.

-- Steve

> Fixes: a05d59a56733 "tracing: Add condition check to RCU lockdep checks"
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> CC: Dave Hansen <dave@sr71.net>
> CC: Steven Rostedt <rostedt@goodmis.org>
> ---
>  include/linux/tracepoint.h | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
> index a5f7f3e..c8e3030 100644
> --- a/include/linux/tracepoint.h
> +++ b/include/linux/tracepoint.h
> @@ -167,10 +167,11 @@ extern void syscall_unregfunc(void);
>   * structure. Force alignment to the same alignment as the section start.
>   *
>   * When lockdep is enabled, we make sure to always do the RCU portions of
> - * the tracepoint code, regardless of whether tracing is on or we match the
> - * condition.  This lets us find RCU issues triggered with tracepoints even
> - * when this tracepoint is off.  This code has no purpose other than poking
> - * RCU a bit.
> + * the tracepoint code, regardless of whether tracing is on. However,
> + * don't check if the condition is false, due to interaction with idle
> + * instrumentation. This lets us find RCU issues triggered with tracepoints
> + * even when this tracepoint is off. This code has no purpose other than
> + * poking RCU a bit.
>   */
>  #define __DECLARE_TRACE(name, proto, args, cond, data_proto, data_args) \
>  	extern struct tracepoint __tracepoint_##name;			\

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] Tracepoint: fix documentation of RCU lockdep checks Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-11-02 23:50 +0100
  [PATCH v2 3/3] trace: emit tracepoint in preempt and irqs off tracer Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2015-11-02 23:50 +0100
  Re: [PATCH 1/3] Tracepoint: fix documentation of RCU lockdep checks Steven Rostedt <rostedt@goodmis.org> - 2015-11-03 00:00 +0100

csiph-web