Re: [PATCH v2 net-next] net: dsa: mv88e6xxx: assert SMI lock

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 net-next] net: dsa: mv88e6xxx: assert SMI lock
Date	2015-11-02 17:40 +0100
Message-ID	<qqqjf-7AX-9@gated-at.bofh.it> (permalink)
References	<qpqY2-3ym-7@gated-at.bofh.it> <qqoUa-6R3-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Nov. Monday 02 (45) 04:02 PM, Andrew Lunn wrote:
> On Fri, Oct 30, 2015 at 06:56:45PM -0400, Vivien Didelot wrote:
> > It's easy to forget to lock the smi_mutex before calling the low-level
> > _mv88e6xxx_reg_{read,write}, so add a assert_smi_lock function in them.
> > 
> > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> 
> Acked-by: Andrew Lunn <andrew@lunn.ch>
> 
> 
> Since there is no followup fixes patch, i assume we actually have it
> correct at the moment?

Ho, I just caught what you meant ;-)

From my (minimal) tests, I didn't see any stack dump yet from setup, FDB
or VLAN operations, looks good so far.

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 net-next] net: dsa: mv88e6xxx: assert SMI lock Andrew Lunn <andrew@lunn.ch> - 2015-11-02 16:10 +0100
  Re: [PATCH v2 net-next] net: dsa: mv88e6xxx: assert SMI lock Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-11-02 16:20 +0100
  Re: [PATCH v2 net-next] net: dsa: mv88e6xxx: assert SMI lock Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-11-02 17:40 +0100

csiph-web