Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1260741

Re: [RFC PATCH net-next 0/6] net: dsa: mv88e6060: cleanup and fix setup

Show all headers | View raw

Hi Neil,

On Nov. Monday 02 (45) 11:57 AM, Neil Armstrong wrote:
> This patchset introduces somes fixes and a registers addressing cleanup for
> the mv88e6060 DSA driver.
> 
> The first patch removes the poll_link as mv88e6xxx.
> The 3 following patchs fixes the setup in regards of the datasheet.
> The 2 last patches introduces a clean header and replaces all magic values.
> 
> Neil Armstrong (6):
>   net: dsa: mv88e6060: remove poll_link callback
>   net: dsa: mv88e6060: use the correct InitReady bit
>   net: dsa: mv88e6060: use the correct MaxFrameSize bit
>   net: dsa: mv88e6060: use the correct bit shift for mac0
>   net: dsa: mv88e6060: add register defines header file
>   net: dsa: mv88e6060: replace magic values with register defines

Nice cleanup. I'll just be a bit picky here, so you may not consider my
comment for this patchset, but maybe for the future ones. Unless I'm
mistaken, there is no reason to group all these patches together.

The first 4 patches are independent fixes, and thus could have been sent
separately to netdev -net.

Then the last 2 ones could have been squashed together, because I don't
see a real value to seperate them since you duplicate some defines, e.g.
REG_PORT. And this patch would be a candidate for netdev -net-next.

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH net-next 0/6] net: dsa: mv88e6060: cleanup and fix setup Neil Armstrong <narmstrong@baylibre.com> - 2015-11-02 12:00 +0100
  Re: [RFC PATCH net-next 0/6] net: dsa: mv88e6060: cleanup and fix  setup Andrew Lunn <andrew@lunn.ch> - 2015-11-02 16:00 +0100
  Re: [RFC PATCH net-next 0/6] net: dsa: mv88e6060: cleanup and fix  setup Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-11-02 16:50 +0100
    Re: [RFC PATCH net-next 0/6] net: dsa: mv88e6060: cleanup and fix  setup Neil Armstrong <narmstrong@baylibre.com> - 2015-11-03 17:30 +0100

csiph-web