Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1260638

Re: [RFC PATCH net-next 2/6] net: dsa: mv88e6060: use the correct InitReady bit

Show all headers | View raw

Hello.

On 11/2/2015 1:57 PM, Neil Armstrong wrote:

> According to the mv88e6060 datasheet, the InitReady bit position
> is 11 and the polarity is inverted.
> Use the bit correctly to detect the end of initialization.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>   drivers/net/dsa/mv88e6060.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/dsa/mv88e6060.c
> index 6885ef5..c10880f 100644
> --- a/drivers/net/dsa/mv88e6060.c
> +++ b/drivers/net/dsa/mv88e6060.c
> @@ -102,7 +102,7 @@ static int mv88e6060_switch_reset(struct dsa_switch *ds)
>   	timeout = jiffies + 1 * HZ;
>   	while (time_before(jiffies, timeout)) {
>   		ret = REG_READ(REG_GLOBAL, 0x00);
> -		if ((ret & 0x8000) == 0x0000)
> +		if ((ret & 0x800) != 0x0000)

    You could as well drop != 0.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH net-next 2/6] net: dsa: mv88e6060: use the correct  InitReady bit Neil Armstrong <narmstrong@baylibre.com> - 2015-11-02 12:00 +0100
  Re: [RFC PATCH net-next 2/6] net: dsa: mv88e6060: use the correct  InitReady bit Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-02 14:10 +0100

csiph-web