[PATCH] toshiba_acpi: Initialize hotkey_event_type variable

From	Azael Avalos <coproscefalo@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] toshiba_acpi: Initialize hotkey_event_type variable
Date	2015-11-02 03:40 +0100
Message-ID	<qqdcm-81B-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some
toshiba models") fixed an issue on some laptops regarding hotkeys
registration, however, if failed to address the initialization of the
hotkey_event_type variable, and thus, it can lead to potential
unwanted effects as the variable is being checked.

This patch initializes such variable to avoid such unwanted effects.

Cc: <stable@vger.kernel.org> # 4.1+
Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
---
Darren,

Sorry for sending this patch this late, I had a really busy week :-(

 drivers/platform/x86/toshiba_acpi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index beb709f..c013029 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -2665,6 +2665,7 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev)
  ret = toshiba_function_keys_get(dev, &dev->special_functions);
  dev->kbd_function_keys_supported = !ret;

+ dev->hotkey_event_type = 0;
  if (toshiba_acpi_setup_keyboard(dev))
  pr_info("Unable to activate hotkeys\n");

-- 
2.6.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] toshiba_acpi: Initialize hotkey_event_type variable Azael Avalos <coproscefalo@gmail.com> - 2015-11-02 03:40 +0100
  Re: [PATCH] toshiba_acpi: Initialize hotkey_event_type variable Darren Hart <dvhart@infradead.org> - 2015-11-04 01:50 +0100
    Re: [PATCH] toshiba_acpi: Initialize hotkey_event_type variable Azael Avalos <coproscefalo@gmail.com> - 2015-11-04 17:10 +0100

csiph-web