Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1262019

Re: [RFC] vfs: don't bother clearing close_on_exec bit for unused fds

Show all headers | View raw

On Tue, 2015-11-03 at 10:41 +0100, Rasmus Villemoes wrote:

> @@ -667,7 +667,7 @@ void do_close_on_exec(struct files_struct *files)
>  		fdt = files_fdtable(files);
>  		if (fd >= fdt->max_fds)
>  			break;
> -		set = fdt->close_on_exec[i];
> +		set = fdt->close_on_exec[i] & fdt->open_fds[i];
>  		if (!set)
>  			continue;
>  		fdt->close_on_exec[i] = 0;

If you don't bother, why leaving this final fdt->close_on_exec[i] = 0 ?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC] vfs: don't bother clearing close_on_exec bit for unused fds Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-03 10:50 +0100
  Re: [RFC] vfs: don't bother clearing close_on_exec bit for unused fds Linus Torvalds <torvalds@linux-foundation.org> - 2015-11-03 23:50 +0100
    Re: [RFC] vfs: don't bother clearing close_on_exec bit for unused fds Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-04 00:20 +0100
  Re: [RFC] vfs: don't bother clearing close_on_exec bit for unused  fds Eric Dumazet <eric.dumazet@gmail.com> - 2015-11-04 02:40 +0100
    Re: [RFC] vfs: don't bother clearing close_on_exec bit for unused fds Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-11-04 12:00 +0100
      Re: [RFC] vfs: don't bother clearing close_on_exec bit for unused  fds Eric Dumazet <eric.dumazet@gmail.com> - 2015-11-04 13:40 +0100

csiph-web